Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752586AbYL2Pfv (ORCPT ); Mon, 29 Dec 2008 10:35:51 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751509AbYL2Pfm (ORCPT ); Mon, 29 Dec 2008 10:35:42 -0500 Received: from mgw2.diku.dk ([130.225.96.92]:60943 "EHLO mgw2.diku.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751179AbYL2Pfl (ORCPT ); Mon, 29 Dec 2008 10:35:41 -0500 Date: Mon, 29 Dec 2008 16:35:38 +0100 (CET) From: Julia Lawall To: Alan Stern Cc: gregkh@suse.de, dbrownell@users.sourceforge.net, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 10/13] drivers/usb/gadget: use USB API functions rather than constants In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1662 Lines: 45 > ... > > > diff --git a/drivers/usb/gadget/file_storage.c b/drivers/usb/gadget/file_storage.c > > index 88fedd0..c44092b 100644 > > --- a/drivers/usb/gadget/file_storage.c > > +++ b/drivers/usb/gadget/file_storage.c > > @@ -248,6 +248,7 @@ > > #include > > #include > > > > +#include > > #include > > #include > > While there's nothing wrong with this part of the patch, it hardly > seems necessary. Was there any reason for including it? The new functions are defined in usb.h. I have added the include in this file and in the file epautoconf.c that this file includes. If it is removed from both, then the code does not compile (after make allyesconfig): In file included from drivers/usb/gadget/file_storage.c:268: drivers/usb/gadget/epautoconf.c: In function 'ep_matches': drivers/usb/gadget/epautoconf.c:79: error: implicit declaration of function 'usb_endpoint_type' drivers/usb/gadget/epautoconf.c:122: error: implicit declaration of function 'usb_endpoint_dir_in' make[1]: *** [drivers/usb/gadget/file_storage.o] Error 1 make: *** [drivers/usb/gadget/file_storage.o] Error 2 While putting it in epautoconf.c would be sufficient, the includes #include #include are already repeated in both, so it would seem reasonable to repeat usb.h in both as well. julia -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/