DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=pacbell.net;
  h=Received:X-YMail-OSG:X-Yahoo-Newman-Property:From:To:Subject:Date:User-Agent:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-Disposition:Message-Id;
  b=FKjBUCE+7obAiSciV8/DLH3yUaTs746hqFzD5pivU76hJuj6B2k10dXn7UpZuazaL834FPDBSeaErG0dV9AVFVgZs7alHGAzhQDU+te2TaiuSR0KJHG7jsW5DjIp5DN7Ixeoz++mtOxupa/hRDJnUsxNuNUWaAuB5os/WbbpjTA=  ;
From: David Brownell <david-b@pacbell.net>
To: Julia Lawall <julia@diku.dk>, Alan Stern <stern@rowland.harvard.edu>
Subject: Re: [PATCH 10/13] drivers/usb/gadget: use USB API functions rather than constants
Date: Mon, 29 Dec 2008 10:14:49 -0800
User-Agent: KMail/1.9.10
Cc: gregkh@suse.de, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
       kernel-janitors@vger.kernel.org
References: <Pine.LNX.4.44L0.0812291025220.2250-100000@iolanthe.rowland.org> <Pine.LNX.4.64.0812291628100.9555@pc-004.diku.dk>
In-Reply-To: <Pine.LNX.4.64.0812291628100.9555@pc-004.diku.dk>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Message-Id: <200812291014.49779.david-b@pacbell.net>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1121
Lines: 34

On Monday 29 December 2008, Julia Lawall wrote:
> > > +#include <linux/usb.h>
> > > ?#include <linux/usb/ch9.h>
> > > ?#include <linux/usb/gadget.h>
> > 
> > While there's nothing wrong with this part of the patch,

Not so; there *is* something wrong in requiring the
peripheral side support to use a host side header.


> > it hardly  
> > seems necessary. ?Was there any reason for including it?
> 
> The new functions are defined in usb.h. I have added the include in 
> this file and in the file epautoconf.c that this file includes. ?If it is 
> removed from both, then the code does not compile (after make 
> allyesconfig):

Those functions were supposed to go into <linux/usb/ch9.h>, as
I recall, since they weren't specific to the host side stack.

Having them added to the wrong file is surely part of why
they've only been used by host side drivers.  :)

- Dave


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/