Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752087AbYL2TC4 (ORCPT ); Mon, 29 Dec 2008 14:02:56 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752097AbYL2TCP (ORCPT ); Mon, 29 Dec 2008 14:02:15 -0500 Received: from fk-out-0910.google.com ([209.85.128.187]:7223 "EHLO fk-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751979AbYL2TCM (ORCPT ); Mon, 29 Dec 2008 14:02:12 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-disposition:message-id:content-type :content-transfer-encoding; b=bHrF4PtTPZgleyqU21xhIYz03PDPFlhSSGNuRlj/Qq63LmDS0yOHF4kx93U+S0eQGs fK1/MKdEv7RRBIbRVSazHByNSZbmFKwjt5NbXgTnkOfkFas+BwG9E7tcQwkeVcNJryWc blhlihbduHBc7qd3RTLKHJ37tp48CqcwCVRro= From: Bartlomiej Zolnierkiewicz To: petkovbb@gmail.com Subject: Re: [PATCH 0/8] ide-cd: first conversion batch Date: Mon, 29 Dec 2008 19:57:39 +0100 User-Agent: KMail/1.10.3 (Linux/2.6.28-rc8-next-20081219; KDE/4.1.3; i686; ; ) Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org References: <1229586052-3542-1-git-send-email-petkovbb@gmail.com> <200812212005.56973.bzolnier@gmail.com> <20081226134556.GA23503@gollum.tnic> In-Reply-To: <20081226134556.GA23503@gollum.tnic> MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200812291957.39757.bzolnier@gmail.com> Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1506 Lines: 35 On Friday 26 December 2008, Borislav Petkov wrote: > Hi Bart, > > On Sun, Dec 21, 2008 at 08:05:56PM +0100, Bartlomiej Zolnierkiewicz wrote: > > [.. ] > > > don't do cdrom_decode_status for DRQ_INTERRUPT devices but this is > > > probably not that relevant anymore since we busy-wait for DRQ to get set > > > through ide_wait_stat, as we talked about it before - it being a bugfix for > > > all atapi devices. If there's still interest for that (and I think it > > > > Yes, this change is OK but for bisectability reasons it would be better > > to do it in pre-patch (which would fix ide-cd.c accordingly). > > > > [ The other changes in functionality are small and acceptable for this > > patch (i.e. ide_wait_stat() prints error message now) except the change > > of the ordering between ->dma_start and ->output_data calls -- which > > also seems to deserve patch on its own. ] > > sorry for the delay but you know how it is, Christmas and all. Anyway, > here are the patches attached as you requested, just in time for the > merge window. np, I was busy with Christmas-fu myself... I applied all three patches but I want them to see some time in linux-next before push to mainline (just-in-case, they should make it into 2.6.29). Thanks, Bart -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/