Date: Mon, 29 Dec 2008 12:34:43 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: avishay@gmail.com, jeff@garzik.org, viro@ZenIV.linux.org.uk,
       linux-fsdevel@vger.kernel.org, osd-dev@open-osd.org,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/9] exofs: file and file_inode operations
Message-Id: <20081229123443.36c022bc.akpm@linux-foundation.org>
In-Reply-To: <4947C685.1000800@panasas.com>
References: <4947BFAA.4030208@panasas.com>
	<4947C685.1000800@panasas.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1395
Lines: 48

On Tue, 16 Dec 2008 17:17:25 +0200
Boaz Harrosh <bharrosh@panasas.com> wrote:

> 
> implementation of the file_operations and inode_operations for
> regular data files.
> 
> Most file_operations are generic vfs implementations except:
> - exofs_truncate will truncate the OSD object as well
> - Generic file_fsync is not good for none_bd devices so open code it
> - The default for .flush in Linux is todo nothing so call exofs_fsync
>   on the file.
> 
> ...
>
> +int exofs_file_fsync(struct file *filp, struct dentry *dentry, int datasync)
> +{
> +	int ret1, ret2;
> +	struct address_space *mapping = filp->f_mapping;
> +
> +	ret1 = filemap_write_and_wait(mapping);
> +	ret2 = file_fsync(filp, dentry, datasync);
> +
> +	return ret1 ? : ret2;

mutter.  That gccism always makes me fall over dazed and confused. 
Maybe that's just me.

Did we really want to call file_fsync() if filemap_write_and_wait() failed?

> +}
>
> ...
>
> +struct file_operations exofs_file_operations = {
> +struct inode_operations exofs_file_inode_operations = {

These both could/should be made const.

> +	.truncate	= exofs_truncate,
> +	.setattr	= exofs_setattr,
> +};

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/