Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754169AbYL2Vgs (ORCPT ); Mon, 29 Dec 2008 16:36:48 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753152AbYL2Vgj (ORCPT ); Mon, 29 Dec 2008 16:36:39 -0500 Received: from smtp.gentoo.org ([140.211.166.183]:55294 "EHLO smtp.gentoo.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752207AbYL2Vgh (ORCPT ); Mon, 29 Dec 2008 16:36:37 -0500 From: Mike Frysinger Organization: wh0rd.org To: Adrian McMenamin Subject: Re: [PATCH] sh: maple: add support for the Maple mouse on the SEGA Dreamcast Date: Mon, 29 Dec 2008 16:36:34 -0500 User-Agent: KMail/1.10.3 (Linux/2.6.28; KDE/4.1.3; x86_64; ; ) Cc: LKML , Dmitry Torokhov , "linux-sh" , "linux-input" , Andrew Morton , Paul Mundt References: <1230578246.6496.25.camel@localhost.localdomain> <200812291602.18572.vapier@gentoo.org> <1230586215.6496.28.camel@localhost.localdomain> In-Reply-To: <1230586215.6496.28.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart4704389.aT7T707mOG"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200812291636.36303.vapier@gentoo.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1755 Lines: 45 --nextPart4704389.aT7T707mOG Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Monday 29 December 2008 16:30:14 Adrian McMenamin wrote: > +static int __devexit remove_maple_mouse(struct device *dev) > +static struct maple_driver dc_mouse_driver =3D { > + .drv =3D { > + .remove =3D remove_maple_mouse, does that really build warning free ? usually you need __devexit_p() in th= e=20 =2Eremove assignment ... =2Dmike --nextPart4704389.aT7T707mOG Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) iQIcBAABAgAGBQJJWULkAAoJEEFjO5/oN/WBiEMP/AiKIeT3N/TrTcJPgYeUfBex qVLMOq+4N+tuVlgV9RdqX//1feVWM2EKJ9gVAx8+zwOLkuZgPmAKSqVPfYxni04q 2jBFIcvzMMFpfqo7GbKv9c/kRJFNg2Ec8BTiIqYsHtlGPhQvSCLxkMib8up8GHX9 Acerdx3C/rTnWdz5PofgfrDGgMtE8qmYnPurJJCoDCBWMaOQw3tSRaAZhvQ3DPdG QxoPL7xPdBH+Mt3QcAeN1+/LduiM8l8tXq+Om/awpo/8VcWUrulZaMUpLb0094M5 H1alPqGfghw9oE9RGPfnI/VEkz+70vcIEJ7Z5eQjEdDMN7mcSW4cPo+IpnqpVgKy rxDG18SPeOk6hgOqi3nQU1LV6OVWa2leOHpct2w9T2ODG9Pw/ipT7p1USBs9vBui yf/kXl2MUbsRdPqcwWDwo7CHiRJhlf5WvLkJ+QyEourtgMRdCZDn1OJAoe0U6b+v 0A7fq5sZaqRDFZF8mto6MRhLmTu4gpRdv+TPk4xt8FuDJYEcXVMDT3kk0/WU92mF VIugXPYdGlC+T7XV2nUc8GMYxIixX0SuSYw0EmJT4qg9L18CyGsnzuYTegvknhk7 VTbu/rT4dhQ9hsIdSWMeMdm+AVvyAAohzvblPDRnAVovBP95cq7C18YeyrIzkjDP ecLO9Kxi25iTvsOZxZzw =Hcx1 -----END PGP SIGNATURE----- --nextPart4704389.aT7T707mOG-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/