DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=sender:date:from:to:cc:subject:message-id:references:mime-version
         :content-type:content-disposition:in-reply-to:user-agent;
        b=oM9EbuCGuzQU507aoPbfHHrAU8m098/s0e1M6vAhev5+wf3vAv/ufOJycVCGWIFw1G
         hPqF8qB30epgKLr6JEyplr9bwspC36BAWAWxY0mz1zKte2fReQr8oqTokPo2HyUoBXpB
         fBF7oNZHpuFBxuvlu7lPTOWf7FscyGEMme+1A=
Date: Tue, 30 Dec 2008 10:01:30 +0200
From: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
       Steven Rostedt <rostedt@goodmis.org>, mingo@elte.hu
Subject: Re: [PATCH] tracing/kmemtrace: normalize the raw tracer event to
	the unified tracing API
Message-ID: <20081230080129.GA10635@localhost>
References: <4959443f.09a1660a.44f3.2686@mx.google.com> <20081229220937.GC5829@nowhere> <1230623364.6091.9.camel@penberg-laptop>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1230623364.6091.9.camel@penberg-laptop>
User-Agent: Mutt/1.5.16 (2007-06-09)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1642
Lines: 42

On Tue, Dec 30, 2008 at 09:49:24AM +0200, Pekka Enberg wrote:
> Hi Frederic,
> 
> On Mon, 2008-12-29 at 23:09 +0100, Frederic Weisbecker wrote:
> > Pekka, note that I would be pleased to add statistical tracing on
> > this tracer, but I would need a hashtable, or an array, or a list, or whatever
> > iterable to insert the data into the stat tracing api.
> > 
> > But I don't know your projects about this... whether you wanted to use a section
> > or something else...
> 
> It really depends on what we're tracing. If we're interested in just the
> allocation hotspots, a section will do just fine. However, if we're
> tracing memory footprint, we need to take into store the object pointer
> returned from kmalloc() and kmem_cache_alloc() so we can update
> call-site statistics properly upon kfree().
> 
> So I suppose we need both, a section for per call-site statistics and a
> hash table for the object -> call-site mapping.
> 
> 		Pekka

Hi Frederic,

Thanks for doing this work.

kmemtrace-user currently shows two main views: per call-site and
per-allocation. For the former, it uses a hashtable to accumulate
statistics. There's also a hashtable for individual allocations (by ptr
address), which we use to check for consistency for example ("if this is
going to be freed, has it been allocated?"). Apart from those two views,
it also shows global statistics.


	Thanks again,
	Eduard

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/