Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753234AbYL3TkU (ORCPT ); Tue, 30 Dec 2008 14:40:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751989AbYL3TkF (ORCPT ); Tue, 30 Dec 2008 14:40:05 -0500 Received: from fg-out-1718.google.com ([72.14.220.159]:38745 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751969AbYL3TkE (ORCPT ); Tue, 30 Dec 2008 14:40:04 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=xe6dCPW53OtkUzOmks3Qj5bFDkfHFsVsZaDHmlzXaYQRtttKFRHskqKZ0v9HvcgRm0 rLmhX1a4FELN7Lw8W221MgJKsaxF0yiEuWRX+G9U//JjVYdqZ40ZiRZCmo1vR56wBjNb MO7KyeNl5Ep+ITE/HENq92WZsRIqO0mp12kXQ= Date: Tue, 30 Dec 2008 22:40:00 +0300 From: Cyrill Gorcunov To: Mauro Carvalho Chehab Cc: Ingo Molnar , linux-dvb-maintainer@linuxtv.org, video4linux-list@redhat.com, linux-kernel@vger.kernel.org, Patrick Boettcher Subject: Re: [GIT PATCHES for 2.6.28] V4L/DVB fixes, crash in af9005_usb_module_init() Message-ID: <20081230194000.GA7420@localhost> References: <20081224121252.7560391e@caramujo.chehab.org> <20081225081907.GA4628@elte.hu> <20081225212459.4c7e31b4@caramujo.chehab.org> <20081226090220.GF755@elte.hu> <20081226111324.3fbb804b@caramujo.chehab.org> <20081226132426.GA26953@elte.hu> <20081227164020.GA9726@elte.hu> <20081227171122.GA20147@localhost> <20081230173310.41711eb9@pedra.chehab.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081230173310.41711eb9@pedra.chehab.org> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1914 Lines: 60 [Mauro Carvalho Chehab - Tue, Dec 30, 2008 at 05:33:10PM -0200] | | On Sat, 27 Dec 2008 20:11:22 +0300 | Cyrill Gorcunov wrote: | | > [Ingo Molnar - Sat, Dec 27, 2008 at 05:40:20PM +0100] | > | | > | * Ingo Molnar wrote: | > | | > | > [...] I have re-enabled the driver in tip/master [...] | > | | > | ok, just got this build failure: | > | | > | drivers/built-in.o: In function `dm1105_probe': | > | dm1105.c:(.devinit.text+0x2298b): undefined reference to `cx24116_attach' | > | make: *** [.tmp_vmlinux1] Error 1 | > | | > | config attached. Can test any fix patch. | > | | > | Ingo | > | | > | > Something like that? | | I suspect that this will work. Could you please send your SOB? | Without problem :) --- Subject: [PATCH] DVB: cx24116 - build fix Add missed MODULE check to eliminate inapropriate declaration being choosed which causes a build error. Signed-off-by: Cyrill Gorcunov --- drivers/media/dvb/frontends/cx24116.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: linux-2.6.git/drivers/media/dvb/frontends/cx24116.h =================================================================== --- linux-2.6.git.orig/drivers/media/dvb/frontends/cx24116.h +++ linux-2.6.git/drivers/media/dvb/frontends/cx24116.h @@ -37,7 +37,8 @@ struct cx24116_config { u8 mpg_clk_pos_pol:0x02; }; -#if defined(CONFIG_DVB_CX24116) || defined(CONFIG_DVB_CX24116_MODULE) +#if defined(CONFIG_DVB_CX24116) || \ + (defined(CONFIG_DVB_CX24116_MODULE) && defined(MODULE)) extern struct dvb_frontend *cx24116_attach( const struct cx24116_config *config, struct i2c_adapter *i2c); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/