To: Peter W Morreale <pmorreale@novell.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] pdflush fix and enhancement
From: Andi Kleen <andi@firstfloor.org>
References: <20081230231152.10427.50620.stgit@hermosa.site>
Date: Wed, 31 Dec 2008 01:28:46 +0100
In-Reply-To: <20081230231152.10427.50620.stgit@hermosa.site> (Peter W. Morreale's message of "Tue, 30 Dec 2008 16:12:29 -0700")
Message-ID: <87fxk5ur0h.fsf@basil.nowhere.org>
User-Agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/21.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 868
Lines: 24

Peter W Morreale <pmorreale@novell.com> writes:

> The following series implements a fix for pdflush thread creation and an
> enhancement for allowing the setting of the minimum and maximun number
> of pdflush threads. 

You forgot to state why the admin should control that?

Each sysctl essentially presents a failure of the automatic tuning
algorithms of the kernel (kernel hackers admitting defeat). 

So a patch adding new ones at least needs a clear rationale what
problem it is trying to fix and why the automatic tuning cannot be
fixed instead to address this case without new knobs.

-Andi

-- 
ak@linux.intel.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/