Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757393AbYLaWQ3 (ORCPT ); Wed, 31 Dec 2008 17:16:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753176AbYLaWQU (ORCPT ); Wed, 31 Dec 2008 17:16:20 -0500 Received: from ozlabs.org ([203.10.76.45]:56243 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753172AbYLaWQU (ORCPT ); Wed, 31 Dec 2008 17:16:20 -0500 From: Rusty Russell To: Linus Torvalds Subject: Re: [PATCH] parisc: fix module loading failure of large kernel modules (take 4) Date: Thu, 1 Jan 2009 08:46:12 +1030 User-Agent: KMail/1.10.3 (Linux/2.6.27-9-generic; KDE/4.1.3; i686; ; ) Cc: Helge Deller , "linux-parisc" , Linux Kernel Development , Kyle McMartin , Randolph Chung , Andrew Morton , Sam Ravnborg , John David Anglin References: <4959346E.7060600@gmx.de> <495B5806.3080505@gmx.de> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200901010846.13881.rusty@rustcorp.com.au> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1477 Lines: 37 On Thursday 01 January 2009 03:59:36 Linus Torvalds wrote: > > On Wed, 31 Dec 2008, Helge Deller wrote: > > > > [PATCH 1/2] module.c: fix module loading failure of large kernel modules > > > > When creating the final layout of a kernel module in memory, allow the > > module loader to reserve some additional memory in front of a given section. > > This is currently only needed for the parisc port which needs to put the > > stub entries there to fulfill the 17/22bit PCREL relocations with large > > kernel modules like xfs. > > > > Differences of this patch to previous versions: > > - added weak funtion arch_module_section_size() > > This doesn't work. > > We've had this bug several times now, and one of them just very recently. > > Some gcc versions will inline weak functions if they are in scope Ah, someone hit this elsewhere and thought this was an arch-specific bug. Any chance we can just kill those compiler versions and move on with our lives? 4.1.3 definitely doesn't have the problem. > We don't write out that whole "__attribute__" crud. I think what you mean is "I prefer __weak". Which is fine, and not trivially disprovable by grep. It's a gratuitous kernelism, but it's an inoffensive one. Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/