Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756035AbYLaRtH (ORCPT ); Wed, 31 Dec 2008 12:49:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755482AbYLaRsz (ORCPT ); Wed, 31 Dec 2008 12:48:55 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:51638 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752233AbYLaRsy (ORCPT ); Wed, 31 Dec 2008 12:48:54 -0500 Date: Wed, 31 Dec 2008 09:47:19 -0800 (PST) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Roland Dreier , Ingo Molnar , Ian Campbell , Jeremy Fitzhardinge cc: Helge Deller , Rusty Russell , linux-parisc , Linux Kernel Development , Kyle McMartin , Randolph Chung , Andrew Morton , Sam Ravnborg , John David Anglin Subject: Re: [PATCH] parisc: fix module loading failure of large kernel modules (take 4) In-Reply-To: Message-ID: References: <4959346E.7060600@gmx.de> <200812310915.41693.rusty@rustcorp.com.au> <495B5806.3080505@gmx.de> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1269 Lines: 45 On Wed, 31 Dec 2008, Roland Dreier wrote: > > Does this mean lib/swiotlb.c is broken now? Yes it does. > It has eg: > > void * __weak swiotlb_alloc_boot(size_t size, unsigned long nslabs) > > and then > > void __init > swiotlb_init_with_default_size(size_t default_size) > { > ... > io_tlb_start = swiotlb_alloc_boot(bytes, io_tlb_nslabs); > > later on in the same file. Good eyes. Ingo? This comes from commit b81ea27b2329bf44b30c427800954f845896d476, by Ian, through Jeremy. > (I just notice this because I saw the warning about swiotlb_alloc_boot() > not being __init but calling __alloc_bootmem_low and so I looked at the > code yesterday) Lucky us. What's nasty about this is that most developers probably have updated versions of gcc, and are then surprised when some odd user has insane behavior that doesn't match the source code - because the compiler did something unexpected. I guess I could make a sparse rule for this, but nobody seems to run or care about sparse anyway. Sad. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/