DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:cc:in-reply-to:mime-version
         :content-type:content-transfer-encoding:content-disposition
         :references;
        b=m6HH1s3Kk0pAVB26Ce2PutOyDo7/tSOsxdkVmJW/mRxUaVBkAFbb+8pHV3Tf2QQ0xq
         cAyGOuk6l9jAzO7/vj31SEvjftwfu3TsuDNASdjm9IRwLzgvJzWe5IHS8IHxz1t5UGz1
         DlZoKltHnbqtoDu7TUAdtbCmOsu1dEsOq6eZ0=
Message-ID: <3f9a31f40812162028j5a0e12f5h2215daae12ce3441@mail.gmail.com>
Date: Wed, 17 Dec 2008 09:58:47 +0530
From: "Jaswinder Singh" <jaswinderlinux@gmail.com>
To: "Ingo Molnar" <mingo@elte.hu>
Subject: Re: [PATCH] x86: traps.c declare functions before they get used
Cc: "Jaswinder Singh" <jaswinder@infradead.org>,
        LKML <linux-kernel@vger.kernel.org>,
        "Andi Kleen" <andi@firstfloor.org>
In-Reply-To: <20081216201956.GA14505@elte.hu>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <1229360145.15326.5.camel@jaswinder.satnam>
	 <20081216201956.GA14505@elte.hu>
Sender: linux-kernel-owner@vger.kernel.org

Hello Ingo,

On Wed, Dec 17, 2008 at 1:49 AM, Ingo Molnar <mingo@elte.hu> wrote:
>> +#ifndef CONFIG_MATH_EMULATION
>>  asmlinkage void math_emulate(long);
>>  #endif
>
> uhm, shouldnt that #ifndef CONFIG_MATH_EMULATION be #ifdef
> CONFIG_MATH_EMULATION?
>

Sorry, but it seems correct to me in traps case will be opposite.

If someone tries to access math_emulate() and MATH_EMULATION is not
defined then he will be trapped ;-)

Thank you,

Jaswinder Singh.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/