Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757551AbYLQHmi (ORCPT ); Wed, 17 Dec 2008 02:42:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755899AbYLQHmK (ORCPT ); Wed, 17 Dec 2008 02:42:10 -0500 Received: from tundra.namei.org ([65.99.196.166]:2859 "EHLO tundra.namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753620AbYLQHmI (ORCPT ); Wed, 17 Dec 2008 02:42:08 -0500 Date: Wed, 17 Dec 2008 18:40:54 +1100 (EST) From: James Morris To: Al Viro cc: linux-audit@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/15] sanitize AUDIT_MQ_SENDRECV In-Reply-To: Message-ID: References: User-Agent: Alpine 1.10 (LRH 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 17 Dec 2008, Al Viro wrote: > > * logging the original value of *msg_prio in mq_timedreceive(2) > is insane - the argument is write-only (i.e. syscall always > ignores the original value and only overwrites it). I wonder if any existing certifications need to be amended. > * merge __audit_mq_timed{send,receive} > * don't do copy_from_user() twice > * don't mess with allocations in auditsc part > * ... and don't bother checking !audit_enabled and !context in there - > we'd already checked for audit_dummy_context(). > > Signed-off-by: Al Viro Reviewed-by: James Morris -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/