Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760192AbYLQIHa (ORCPT ); Wed, 17 Dec 2008 03:07:30 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752882AbYLQIHS (ORCPT ); Wed, 17 Dec 2008 03:07:18 -0500 Received: from smtp-out.google.com ([216.239.45.13]:28487 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752805AbYLQIHQ (ORCPT ); Wed, 17 Dec 2008 03:07:16 -0500 DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=mime-version:in-reply-to:references:date:message-id:subject:from:to: cc:content-type:content-transfer-encoding; b=I/mnaQ0LexOv4LHEptYA07EsdO0pMgMuiIJ4ZPobrtLysIiEyz5ojawFji3xXtRMX f13nsrESDRdUg4hINC5Jg== MIME-Version: 1.0 In-Reply-To: <20081216101551.GA27481@elte.hu> References: <20081216091509.GA29872@elte.hu> <49477452.6030307@goop.org> <20081216101551.GA27481@elte.hu> Date: Wed, 17 Dec 2008 00:07:12 -0800 Message-ID: Subject: Re: [patch] x86: convert rdtscll() to use __native_read_tsc From: Ken Chen To: Ingo Molnar Cc: Jeremy Fitzhardinge , Linux Kernel Mailing List , "H. Peter Anvin" , Thomas Gleixner Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 16, 2008 at 2:15 AM, Ingo Molnar wrote: > agreed mostly, with this twist: vdso inlining dependencies should be > expressed explicitly, via: > > native_vread_tsc() > > but we can also make native_read_tsc() __always_inline [it's a single > instruction with basically no preparatory halo around that instruction] > and document the vdso detail there. Given that vdso already uses the inline version of __native_read_tsc, we don't really have churn all that code around. I also take your analysis as there is no issue in converting rdtscll() to __native_read_tsc(). Would it be possible for you to merge the patch then? - Ken -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/