Date: Wed, 17 Dec 2008 09:40:15 +0000
From: Al Viro <viro@ZenIV.linux.org.uk>
To: James Morris <jmorris@namei.org>
Cc: Al Viro <viro@ftp.linux.org.uk>, linux-audit@redhat.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/15] sanitize AUDIT_MQ_SENDRECV
Message-ID: <20081217094015.GD28946@ZenIV.linux.org.uk>
References: <E1LCohe-0000C7-TH@ZenIV.linux.org.uk> <alpine.LRH.1.10.0812171839080.22856@tundra.namei.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.LRH.1.10.0812171839080.22856@tundra.namei.org>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org

On Wed, Dec 17, 2008 at 06:40:54PM +1100, James Morris wrote:
> On Wed, 17 Dec 2008, Al Viro wrote:
> 
> > 
> > * logging the original value of *msg_prio in mq_timedreceive(2)
> >   is insane - the argument is write-only (i.e. syscall always
> >   ignores the original value and only overwrites it).
> 
> I wonder if any existing certifications need to be amended.

I rather doubt it, but I really don't know the bureaucracy of that.
Just to clarify:
	Old code logs the value of *msg_prio; that value is always
ignored by syscall (it may store something there, but that's it -
pure output parameter)
	New code does not change the format of log message; the value
in that field of the message is replaced with 0.  That's the only
difference.

Whether that requires amending of the existing certs... bugger if I know.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/