Message-ID: <49491D88.3020106@diamondcut.com.br>
Date: Wed, 17 Dec 2008 13:40:56 -0200
From: "Renato S. Yamane" <yamane@diamondcut.com.br>
User-Agent: Thunderbird 2.0.0.18 (X11/20081105)
MIME-Version: 1.0
To: Jeff Layton <jlayton@redhat.com>
CC: torvalds@linux-foundation.org, sfrench@gmail.com,
        linux-kernel@vger.kernel.org, stable@kernel.org,
        linux-cifs-client@lists.samba.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] cifs: fix buffer overrun in parse_DFS_referrals
References: <1229513513-16445-1-git-send-email-jlayton@redhat.com>
In-Reply-To: <1229513513-16445-1-git-send-email-jlayton@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

Jeff Layton wrote:
> ---
>  fs/cifs/cifssmb.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c
> index 9395928..824df14 100644
> --- a/fs/cifs/cifssmb.c
> +++ b/fs/cifs/cifssmb.c
> @@ -3992,7 +3992,8 @@ parse_DFS_referrals(TRANSACTION2_GET_DFS_REFER_RSP *pSMBr,
>  
>  		node->flags = le16_to_cpu(pSMBr->DFSFlags);
>  		if (is_unicode) {
> -			__le16 *tmp = kmalloc(strlen(searchName)*2, GFP_KERNEL);
> +			__le16 *tmp = kmalloc(strlen(searchName)*2 + 2,
> +						GFP_KERNEL);
>  			cifsConvertToUCS((__le16 *) tmp, searchName,
>  					PATH_MAX, nls_codepage, remap);
>  			node->path_consumed = hostlen_fromUCS(tmp,

This patch can't be applied in -stable release:

yamane@mandachuva:~/kernel/linux-2.6.27.9$ patch -p1 < cifs.patch
patching file fs/cifs/cifssmb.c
patch unexpectedly ends in middle of line
Hunk #1 FAILED at 3992.
1 out of 1 hunk FAILED -- saving rejects to file fs/cifs/cifssmb.c.rej

Best regards,
Renato
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/