Date: Wed, 17 Dec 2008 23:52:28 +0100
From: Frederik Deweerdt <frederik.deweerdt@xprog.eu>
To: Eric Paris <eparis@redhat.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
        kosaki.motohiro@jp.fujitsu.com, hch@infradead.org
Subject: Re: [PATCH] sys_execve and sys_uselib do not call into fsnotify
Message-ID: <20081217225228.GB31115@gambetta>
References: <1229540000.3384.40.camel@localhost.localdomain> <20081217190433.GA31115@gambetta> <1229541741.3384.48.camel@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1229541741.3384.48.camel@localhost.localdomain>
User-Agent: Mutt/1.5.17+20080114 (2008-01-14)
Sender: linux-kernel-owner@vger.kernel.org

On Wed, Dec 17, 2008 at 02:22:21PM -0500, Eric Paris wrote:
> On Wed, 2008-12-17 at 20:04 +0100, Frederik Deweerdt wrote:
> > Just curious, isn't the fact that the open still may fail a problem?
> > For example, if the lib is not executable in sys_uselib or if the file
> > was denied write access in open_exec.
> 
> I could be convinced to change it but like what I have.  At this point
> the file is open.  If it fails after this we are going to call fput()
> which calls __fput() which calls fsnotify_close().  Seemed odd to leave
> a close without an open (although that's what we have today.)
> 
> This doesn't mean the syscall was successful, but the file was opened,
> and it will be closed....
OK, thanks for clarifying,

Frederik

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/