Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752570AbYLQXEA (ORCPT ); Wed, 17 Dec 2008 18:04:00 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752355AbYLQXDv (ORCPT ); Wed, 17 Dec 2008 18:03:51 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:40384 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752306AbYLQXDu (ORCPT ); Wed, 17 Dec 2008 18:03:50 -0500 Date: Wed, 17 Dec 2008 15:03:00 -0800 From: Andrew Morton To: Eric Paris Cc: linux-kernel@vger.kernel.org, kosaki.motohiro@jp.fujitsu.com, hch@infradead.org Subject: Re: [PATCH] sys_execve and sys_uselib do not call into fsnotify Message-Id: <20081217150300.fafcdda8.akpm@linux-foundation.org> In-Reply-To: <1229540000.3384.40.camel@localhost.localdomain> References: <1229540000.3384.40.camel@localhost.localdomain> X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.20; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 17 Dec 2008 13:53:20 -0500 Eric Paris wrote: > sys_execve and sys_uselib do not call into fsnotify so inotify does not get > open events for these types of syscalls. This patch simply makes the > requisite fsnotify calls. These two functions are grovelling around in pretty low-level fs operations. One wonders whether they could be converted (ie: cleaned up) to use do_sys_open() or some other such higher-level thing. That way, this fsnotify bug would be magically fixed, too. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/