From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] sys_execve and sys_uselib do not call into fsnotify
Cc: kosaki.motohiro@jp.fujitsu.com, Eric Paris <eparis@redhat.com>,
        linux-kernel@vger.kernel.org, hch@infradead.org
In-Reply-To: <20081217150300.fafcdda8.akpm@linux-foundation.org>
References: <1229540000.3384.40.camel@localhost.localdomain> <20081217150300.fafcdda8.akpm@linux-foundation.org>
Message-Id: <20081218113729.6168.KOSAKI.MOTOHIRO@jp.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Date: Thu, 18 Dec 2008 11:39:23 +0900 (JST)
Sender: linux-kernel-owner@vger.kernel.org

> On Wed, 17 Dec 2008 13:53:20 -0500
> Eric Paris <eparis@redhat.com> wrote:
> 
> > sys_execve and sys_uselib do not call into fsnotify so inotify does not get
> > open events for these types of syscalls.  This patch simply makes the
> > requisite fsnotify calls.
> 
> These two functions are grovelling around in pretty low-level fs
> operations.  One wonders whether they could be converted (ie: cleaned
> up) to use do_sys_open() or some other such higher-level thing.
> 
> That way, this fsnotify bug would be magically fixed, too.

hmm..

In current implementaion, do_sys_open() call fd_install().
then, it cause /proc/{pid}/fd entry change. iow, compatibility break.

Yup, it is fixable. but I think Eric's implementation is simpler.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/