Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752867AbYLRNb5 (ORCPT ); Thu, 18 Dec 2008 08:31:57 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750853AbYLRNbr (ORCPT ); Thu, 18 Dec 2008 08:31:47 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:58763 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751093AbYLRNbr (ORCPT ); Thu, 18 Dec 2008 08:31:47 -0500 Date: Thu, 18 Dec 2008 14:31:34 +0100 From: Ingo Molnar To: Ken Chen Cc: Jeremy Fitzhardinge , Linux Kernel Mailing List , "H. Peter Anvin" , Thomas Gleixner Subject: Re: [patch] x86: convert rdtscll() to use __native_read_tsc Message-ID: <20081218133134.GH32135@elte.hu> References: <20081216091509.GA29872@elte.hu> <49477452.6030307@goop.org> <20081216101551.GA27481@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Ken Chen wrote: > On Tue, Dec 16, 2008 at 2:15 AM, Ingo Molnar wrote: > > agreed mostly, with this twist: vdso inlining dependencies should be > > expressed explicitly, via: > > > > native_vread_tsc() > > > > but we can also make native_read_tsc() __always_inline [it's a single > > instruction with basically no preparatory halo around that instruction] > > and document the vdso detail there. > > Given that vdso already uses the inline version of __native_read_tsc, we > don't really have churn all that code around. I also take your analysis > as there is no issue in converting rdtscll() to __native_read_tsc(). > Would it be possible for you to merge the patch then? yep, i already did that when i replied to your mail, it's in tip/x86/time. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/