Date: Thu, 18 Dec 2008 11:58:02 -0500
From: Mathieu Desnoyers <compudj@krystal.dyndns.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Ingo Molnar <mingo@elte.hu>, Andrew Morton <akpm@linux-foundation.org>,
        Pekka Enberg <penberg@cs.helsinki.fi>, linux-kernel@vger.kernel.org,
        Steven Rostedt <rostedt@goodmis.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        ltt-dev@lists.casi.polymtl.ca, Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [ltt-dev] [PATCH] Simple LTTng userspace events through debugfs
Message-ID: <20081218165802.GA16072@Krystal>
References: <20081215231040.GA5936@Krystal> <20081216194201.GE843@elte.hu> <20081217041628.GA5409@Krystal> <20081217173223.GA32699@Krystal> <20081218085018.8bd1fd92.randy.dunlap@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
In-Reply-To: <20081218085018.8bd1fd92.randy.dunlap@oracle.com>
User-Agent: Mutt/1.5.16 (2007-06-11)
Sender: linux-kernel-owner@vger.kernel.org

* Randy Dunlap (randy.dunlap@oracle.com) wrote:
> On Wed, 17 Dec 2008 12:32:24 -0500 Mathieu Desnoyers wrote:
> 
> > Index: linux-2.6-lttng/ltt/ltt-userspace-event.c
> > ===================================================================
> > --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> > +++ linux-2.6-lttng/ltt/ltt-userspace-event.c	2008-12-17 12:03:43.000000000 -0500
> > @@ -0,0 +1,129 @@
> > +
> > +/**
> > + * write_event: write a userspace string into the trace stream
> 
> Hi Mathieu,
> 
> Please make above line:
> 
>  * write_event - write a userspace string into the trace system
> 

That for the review,

I'll have to go through all the LTTng tree and fix the kerneldoc.

Mathieu

> Thanks.
> 
> > + * @file: file pointer
> > + * @user_buf: user string
> > + * @count: length to copy, including the final NULL
> > + * @ppos: unused
> > + *
> > + * Copy a string into a trace event, in channel "userspace", event "event".
> > + * Copies until either \n or \0 is reached.
> > + * On success, returns the number of bytes copied from the source, including the
> > + * \n or \0 character (if there was one in the count range). It cannot return
> > + * more than count.
> > + * Inspired from tracing_mark_write implementation from Steven Rostedt and
> > + * Ingo Molnar.
> > + */
> > +static ssize_t write_event(struct file *file, const char __user *user_buf,
> > +		size_t count, loff_t *ppos)
> > +{
> 
> 
> ---
> ~Randy
> 

-- 
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/