Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758689AbZABRir (ORCPT ); Fri, 2 Jan 2009 12:38:47 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757456AbZABRii (ORCPT ); Fri, 2 Jan 2009 12:38:38 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:60194 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757406AbZABRii (ORCPT ); Fri, 2 Jan 2009 12:38:38 -0500 Date: Fri, 2 Jan 2009 09:38:14 -0800 (PST) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Ingo Molnar cc: David Miller , akpm@linux-foundation.org, rdreier@cisco.com, ian.campbell@citrix.com, jeremy.fitzhardinge@citrix.com, deller@gmx.de, rusty@rustcorp.com.au, linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, kyle@mcmartin.ca, randolph@tausq.org, sam@ravnborg.org, dave@hiauly1.hia.nrc.ca Subject: Re: [PATCH] kbuild: Disallow GCC 4.1.0 / 4.1.1 In-Reply-To: Message-ID: References: <20081231105425.9ccac21d.akpm@linux-foundation.org> <20081231.141408.60544902.davem@davemloft.net> <20090102115547.GB3027@elte.hu> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1253 Lines: 32 On Fri, 2 Jan 2009, Linus Torvalds wrote: > > I think this is wrong. > > Just move the check into In fact, looking at that whole mess, I redid it all. It was disgusting how conditionals in gcc4.h needed to double-check that __GNUC__ really was 4 (rather than something bigger), which largely negated the whole nice clean compiler version separation. I pushed out my preferred version, which fixes up the whole thing. The gcc4 header file now only gets included for __GNUC__ == 4, and when we ever see a __GNUC__ of 5, it will automatically DTRT and try to include instead of #4. And then the check in gcc4.h for 4.1.0 and 4.1.1 is much simplified. The two patches I pushed out add functionality, but don't actually add any new lines (the first simplification patch removes more lines than it adds, and the second one that adds the __weak bug test adds as mahy lines as the cleanup removed). And it all looks more logical too, imho. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/