Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758894AbZABSCK (ORCPT ); Fri, 2 Jan 2009 13:02:10 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757443AbZABSB4 (ORCPT ); Fri, 2 Jan 2009 13:01:56 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:33799 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757125AbZABSBz (ORCPT ); Fri, 2 Jan 2009 13:01:55 -0500 Date: Fri, 2 Jan 2009 19:01:10 +0100 From: Ingo Molnar To: Linus Torvalds Cc: David Miller , akpm@linux-foundation.org, rdreier@cisco.com, ian.campbell@citrix.com, jeremy.fitzhardinge@citrix.com, deller@gmx.de, rusty@rustcorp.com.au, linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, kyle@mcmartin.ca, randolph@tausq.org, sam@ravnborg.org, dave@hiauly1.hia.nrc.ca Subject: Re: [PATCH] kbuild: Disallow GCC 4.1.0 / 4.1.1 Message-ID: <20090102180110.GA7425@elte.hu> References: <20081231105425.9ccac21d.akpm@linux-foundation.org> <20081231.141408.60544902.davem@davemloft.net> <20090102115547.GB3027@elte.hu> <20090102174641.GA27287@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1178 Lines: 34 * Linus Torvalds wrote: > > > On Fri, 2 Jan 2009, Ingo Molnar wrote: > > > > The gcc3 check for gcc 3.0 and 3.1 can be pushed into gcc3 as well - not > > sure whether you fixed that. (i fixed it in the patch i just sent - but i > > didnt notice the gcc5 mess in gcc4.h that you fixed) > > I just dropped it. Gcc 3.0 and 3.1 are so old that we simply don't care. we didnt support it for quite some time. If you look at that ugly version check you replaced: #if __GNUC__ >= 4 && !gcc41_inlining_bug # include #elif __GNUC__ == 3 && __GNUC_MINOR__ >= 2 # include #else # error Sorry, your compiler is too old, too buggy or not recognized. #endif it has a hidden 'gcc 3.0 / 3.1 is not supported' condition in it. So what i tried to point out that your patch causes a regression here - we dont filter out gcc 3.0/3.1 out anymore. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/