Date: Fri, 2 Jan 2009 19:58:29 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Pekka Enberg <penberg@cs.helsinki.fi>,
       Rusty Russell <rusty@rustcorp.com.au>, Mike Travis <travis@sgi.com>
Cc: Jaswinder Singh Rajput <jaswinder@infradead.org>, hpa@kernel.org,
       x86 maintainers <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: cpuid.c fix style problems
Message-ID: <20090102185829.GA14249@elte.hu>
References: <1230721188.3738.2.camel@jaswinder.satnam> <84144f020812310501w4c64de85r9125cfacccc5ae97@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <84144f020812310501w4c64de85r9125cfacccc5ae97@mail.gmail.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 756
Lines: 21


* Pekka Enberg <penberg@cs.helsinki.fi> wrote:

> On Wed, Dec 31, 2008 at 12:59 PM, Jaswinder Singh Rajput
> <jaswinder@infradead.org> wrote:
> >        cpu = iminor(file->f_path.dentry->d_inode);
> > -       if (cpu >= NR_CPUS || !cpu_online(cpu)) {
> > +       if (cpu >= num_possible_cpus() || !cpu_online(cpu)) {
> 
> How come you didn't convert the first part of the expression to use
> cpu_possible()?

i skipped this bit btw., as it got mooted by the cleanups in the cpumask 
and cpus4096 trees.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/