Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759232AbZABTVZ (ORCPT ); Fri, 2 Jan 2009 14:21:25 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754651AbZABTVQ (ORCPT ); Fri, 2 Jan 2009 14:21:16 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:51512 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752046AbZABTVQ (ORCPT ); Fri, 2 Jan 2009 14:21:16 -0500 Date: Fri, 2 Jan 2009 20:20:58 +0100 From: Ingo Molnar To: Ravikiran G Thirumalai Cc: linux-kernel@vger.kernel.org, travis@sgi.com, stable@kernel.org, shai@scalex86.org Subject: Re: [patch] x86: Fix incorrect __read_mostly on _boot_cpu_pda Message-ID: <20090102192058.GD14249@elte.hu> References: <20081231214446.GA6856@localdomain> <20090102160949.GF1180@elte.hu> <20090102185524.GB6856@localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090102185524.GB6856@localdomain> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1258 Lines: 34 * Ravikiran G Thirumalai wrote: > On Fri, Jan 02, 2009 at 05:09:51PM +0100, Ingo Molnar wrote: > > > >* Ravikiran G Thirumalai wrote: > > > >> The pda rework (commit 3461b0af025251bbc6b3d56c821c6ac2de6f7209) > >> to remove static boot cpu pdas introduced a bug. _boot_cpu_pda is the > >> actual pda used by the boot cpu and is definitely not "__read_mostly" and > >> ended up polluting the read mostly section with writes. This bug caused > >> regression of about 8-10% on certain syscall intensive workloads. > >> > >> Signed-off-by: Ravikiran Thirumalai > > > >applied to tip/x86/urgent, with a Cc: stable tag. Thanks, > > > > Thanks! > > Stable maintainers, please consider this for 2.6.27 stable as well (in > addition to 28). (Attaching the tip/x86/urgent commit as reference to > the patch) i have added a -stable tag to the commit - please only put it into -stable once it hits Linus's tree. (in the next couple of days) > Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/