From: Arnd Bergmann <arnd@arndb.de>
To: Mike Frysinger <vapier@gentoo.org>
Subject: Re: [PATCH] headers_check.pl: disallow extern's
Date: Sat, 3 Jan 2009 00:59:18 +0100
User-Agent: KMail/1.9.9
Cc: Sam Ravnborg <sam@ravnborg.org>, linux-kernel@vger.kernel.org
References: <1230363816-24097-1-git-send-email-vapier@gentoo.org> <200812311758.04516.arnd@arndb.de> <200812311732.40076.vapier@gentoo.org>
In-Reply-To: <200812311732.40076.vapier@gentoo.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 8BIT
Content-Disposition: inline
Message-Id: <200901030059.18438.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1138
Lines: 28

On Wednesday 31 December 2008, Mike Frysinger wrote:
> On Wednesday 31 December 2008 11:58:03 Arnd Bergmann wrote:
>
> > Not sure if we can detect the other form reliably from perl.
> 
> yes, i already mentioned both of these issues. ?that's why i suggested we 
> start adding "extern" to all the headers (or at least the userspace ones).

The general trend seems to be to remove the "extern" keyword from
kernel headers, because it is not interpreted, just like the 'auto'
keyword. In fact, only few of them currently carry the extern keyword:

$ ctags -f- -R --c-kinds=p obj/usr/include/  | grep extern | wc -l
33

$ ctags -f- -R --c-kinds=p obj/usr/include/  | grep -v extern | wc -l
191

Note that this is a completely separate issue from extern variable
declarations, which should to be disallowed in any case, and are easy
to detect as they always require the extern keyword.

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/