Message-ID: <49600856.8030500@s5r6.in-berlin.de>
Date: Sun, 04 Jan 2009 01:52:38 +0100
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.18) Gecko/20081116 SeaMonkey/1.1.13
MIME-Version: 1.0
To: linux1394-devel@lists.sourceforge.net
CC: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firewire: cdev: fix documentation of FW_CDEV_IOC_GET_INFO
References: <tkrat.c7deb6ca39b7041e@s5r6.in-berlin.de>
In-Reply-To: <tkrat.c7deb6ca39b7041e@s5r6.in-berlin.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 943
Lines: 24

I wrote:
> The FW_CDEV_IOC_GET_INFO ioctl looks at client->device->config_rom, not
> at the local node's config ROM.
> 
> We could fix the implementation or the documentation.  I believe the way
> how it is currently implemented is more useful than the way how it is
> currently documented, hence let's change only the documentation.
...
>   * struct fw_cdev_get_info - General purpose information ioctl
...
>   * @rom:	If non-zero, address of a buffer to be filled by a copy of the
> - *		local node's configuration ROM
> + *		device's configuration ROM

Of course libdc1394 uses the ABI already as implemented, not as documented.
-- 
Stefan Richter
-=====-==--= ---= --=--
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/