Message-ID: <4960769D.2020509@panasas.com>
Date: Sun, 04 Jan 2009 10:43:09 +0200
From: Boaz Harrosh <bharrosh@panasas.com>
User-Agent: Thunderbird/3.0a2 (X11; 2008072418)
MIME-Version: 1.0
To: Pavel Machek <pavel@suse.cz>
CC: Andrew Morton <akpm@linux-foundation.org>, avishay@gmail.com,
       jeff@garzik.org, viro@ZenIV.linux.org.uk, linux-fsdevel@vger.kernel.org,
       osd-dev@open-osd.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/9] exofs: osd Swiss army knife
References: <4947BFAA.4030208@panasas.com> <1229439174-30492-1-git-send-email-bharrosh@panasas.com> <20081229122959.2cb48cf7.akpm@linux-foundation.org> <20090102165201.GC1555@ucw.cz>
In-Reply-To: <20090102165201.GC1555@ucw.cz>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1743
Lines: 51

Pavel Machek wrote:
> Hi!
> 
>>> In this patch are all the osd infrastructure that will be used later
>>> by the file system.
>>>
>>> Also the declarations of constants, on disk structures, and prototypes.
>>>
>>> And the Kbuild+Kconfig files needed to build the exofs module.
>>>
>>>
>>> ...
>>>
>>> +struct exofs_sb_info {
>>> +	struct osd_dev	*s_dev;			/* returned by get_osd_dev    */
>>> +	uint64_t	s_pid;			/* partition ID of file system*/
>>> +	int		s_timeout;		/* timeout for OSD operations */
>>> +	uint32_t	s_nextid;		/* highest object ID used     */
>>> +	uint32_t	s_numfiles;		/* number of files on fs      */
>>> +	spinlock_t	s_next_gen_lock;	/* spinlock for gen # update  */
>>> +	u32		s_next_generation;	/* next gen # to use          */
>>> +	atomic_t	s_curr_pending;		/* number of pending commands */
>>> +	uint8_t		s_cred[OSD_CAP_LEN];	/* all-powerful credential    */
>>> +};
>>> +
>>> +/*
>>> + * our inode flags
>>> + */
>>> +#ifdef ARCH_HAS_ATOMIC_UNSIGNED
>> This doesn't exist, and it would be fairly bad to introduce it.  Please
>> kill the ifdefs.
>>
>>> +typedef unsigned exofs_iflags_t;
>>> +#else
>>> +typedef unsigned long exofs_iflags_t;
>>> +#endif
>> Then please kill the typedef altogether and replace it with `unsigned
>> long' everywhere
> 
> Hmmm.. .and at a note somewhere that we assume unsigned long to be atomic...?
> 

I think I'll just use unsigned. It's more then enough I'm not using more then 3
bits for now. Is unsigned workable for all ARCHs?

Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/