Date: Sun, 4 Jan 2009 12:19:09 +0000
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Tollef Fog Heen <tfheen@err.no>
Cc: linux-kernel@vger.kernel.org, werner@cornelius-consult.de,
       frank@kingswood-consulting.co.uk
Subject: Re: [PATCH] Winchiphead 340/1: full baud rate and status/control
 line support
Message-ID: <20090104121909.3e4de876@lxorguk.ukuu.org.uk>
In-Reply-To: <87sknzs79y.fsf@qurzaw.linpro.no>
References: <200807290254.m6T2sIBG010575@imap1.linux-foundation.org>
	<20080729104331.367fde6b@lxorguk.ukuu.org.uk>
	<87ej3d4zv3.fsf_-_@xoog.err.no>
	<20080921151407.10c89452@lxorguk.ukuu.org.uk>
	<87sknzs79y.fsf@qurzaw.linpro.no>
Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street,
 Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a
 Lloegr o'r rhif cofrestru 3798903
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 632
Lines: 14

> | 
> | This could race another set_handshake ? I'm not sure it matters and I'd
> | suggest that stuff gets fixed after this is submitted separately
> 
> What's the easiest way to fix this?

It can sleep so probably all the cases where handshake lines are updated
need to use a mutex to protect them. That will depend if any occur in the
IRQ paths in which case it gets a lot trickier.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/