Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758924AbZADR5m (ORCPT ); Sun, 4 Jan 2009 12:57:42 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751772AbZADR5d (ORCPT ); Sun, 4 Jan 2009 12:57:33 -0500 Received: from wa-out-1112.google.com ([209.85.146.182]:1817 "EHLO wa-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751369AbZADR5c (ORCPT ); Sun, 4 Jan 2009 12:57:32 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=urovvp7fEZ0ncjo781dE2H/29fW9UrbJ1QCO+EEc2tR30uq2OfFVKpE6PmJBaZFxpY adrLcvwO2aHTLw4rAWOfzO5NNsy40g7CtLO0326NcGznGD8I4HWvxA96E2DC4N3TYhi2 bVMJ8eTTV8DMP3TjZ0CcZ/8Ch9E7pTxFbEKuk= Message-ID: <3f9a31f40901040957g5a391408u5cda93c4acb66e9d@mail.gmail.com> Date: Sun, 4 Jan 2009 23:27:31 +0530 From: "Jaswinder Singh Rajput" To: "Ingo Molnar" Subject: Re: [PATCH -tip] x86: setup.c fix style problems Cc: "Jaswinder Singh Rajput" , "x86 maintainers" , LKML In-Reply-To: <20090104172114.GA32425@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <1231066898.27852.29.camel@jaswinder.satnam> <20090104172114.GA32425@elte.hu> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1113 Lines: 31 On Sun, Jan 4, 2009 at 10:51 PM, Ingo Molnar wrote: > > * Jaswinder Singh Rajput wrote: > >> Impact: cleanup, fix style problems, more readable >> >> Fixes style problems: >> WARNING: Use #include instead of >> WARNING: Use #include instead of >> WARNING: Use #include instead of >> WARNING: externs should be avoided in .c files >> ERROR: code indent should use tabs where possible >> >> total: 2 errors, 4 warnings > > doesnt build on some configs: > > arch/x86/kernel/setup.c:943: error: implicit declaration of function 'prefill_possible_map' > This problem will only arise if CONFIG_SMP is not defined. Then linux/smp.h will not include asm/smp.h But why we are keeping non SMP stuff in asm/smp.h, we need to fix this. JSR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/