Message-ID: <4961241C.5020503@s5r6.in-berlin.de>
Date: Sun, 04 Jan 2009 22:03:24 +0100
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.18) Gecko/20081116 SeaMonkey/1.1.13
MIME-Version: 1.0
To: Bill Fink <billfink@mindspring.com>
CC: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
       Harvey Harrison <harvey.harrison@gmail.com>
Subject: Re: [PATCH 2/2] ieee1934: dv1394 interrupt enabling/disabling broken
 on big-endian
References: <1229210489.11257.16.camel@brick>	<4944561D.4010608@s5r6.in-berlin.de>	<20081213204137.d150645c.billfink@mindspring.com>	<49446923.5040606@s5r6.in-berlin.de>	<20081223172300.5bd19846.billfink@mindspring.com>	<20081225220244.1eacb39d.billfink@mindspring.com>	<495F976C.8030105@s5r6.in-berlin.de> <20090103211843.d36d252f.billfink@mindspring.com>
In-Reply-To: <20090103211843.d36d252f.billfink@mindspring.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 925
Lines: 21

Bill Fink wrote:
> Although I admit to being mystified how it works both
> before and after the patch, since the cpu_to_le32() calls that were
> added should result in byte swapping on PPC that wasn't being done
> before.  I guess that either the code paths involved aren't actually
> being triggered by my xine DV viewing, or there's some fortuitous
> palindromic setting of bits.

I agree.  If I had more spare time for these things I would try to find
out what's really going on.  But since the patch really looks like the
right thing to do and doesn't regress, I will send it in without further
investigation.
-- 
Stefan Richter
-=====-==--= ---= --=--
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/