Message-ID: <49614243.70102@knaff.lu>
Date: Mon, 05 Jan 2009 00:12:03 +0100
From: Alain Knaff <alain@knaff.lu>
User-Agent: Thunderbird 2.0.0.18 (X11/20081125)
MIME-Version: 1.0
To: "H. Peter Anvin" <hpa@zytor.com>
CC: linux-kernel@vger.kernel.org
Subject: Re: update8 [PATCH 2/5] init: bzip2 or lzma -compressed kernels and
 initrds
References: <200901042146.n04LkHgP005837@hitchhiker.hitchhiker.org.lu.hitchhiker.org.lu> <4961415C.1050708@zytor.com>
In-Reply-To: <4961415C.1050708@zytor.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1585
Lines: 47

H. Peter Anvin wrote:
> Hi Alain,
> 
> Looking pretty good now.  The only issues that I see so far are:
> 
> - Putting the kernel compression selection in init/Kconfig isn't going
>   to work too well, since it affects all architectures, and not all
>   architectures even do their own decompression (for quite a few
>   architectures it's the boot loader's responsibility.)
> 
>   I see two options here: either have this be parameterized by the arch
>   Kconfig files, or simply move this chunk into arch/*/Kconfig as part
>   of the arch-enablement patches.  The latter is probably the simplest,
>   even if it means some replicated code.
> 
>   Let me know what you think

What do you mean "parametrized by the arch Kconfig files"? Does this
mean that it would still be in the global files, but would be enabled by
some kind of switch or preprocessor macro in the arch dependant file? If
easily doable, this would IMHO be preferable.

However, if not easily feasible, I'm also ok with duplication.

> -- I can do this pretty easily while
>   importing, so you don't need to submit a full new patchset.

Thanks, that would be nice.

> - I did a followon patch (attached) to change the ramdisk compression
>   search to table driven.  Since I already did the followon patch, don't
>   worry about it.
> 
> 	-hpa
> 
> 

Ok

Thanks,

Alain
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/