Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751610AbZAEFGk (ORCPT ); Mon, 5 Jan 2009 00:06:40 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750742AbZAEFGc (ORCPT ); Mon, 5 Jan 2009 00:06:32 -0500 Received: from casper.infradead.org ([85.118.1.10]:33110 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750726AbZAEFGb (ORCPT ); Mon, 5 Jan 2009 00:06:31 -0500 Subject: Re: [PATCH -tip] x86: setup.c fix style problems From: Jaswinder Singh Rajput To: Ingo Molnar Cc: Jaswinder Singh Rajput , x86 maintainers , LKML In-Reply-To: <20090104203433.GC1132@elte.hu> References: <1231066898.27852.29.camel@jaswinder.satnam> <20090104172114.GA32425@elte.hu> <3f9a31f40901040957g5a391408u5cda93c4acb66e9d@mail.gmail.com> <20090104203433.GC1132@elte.hu> Content-Type: text/plain Date: Mon, 05 Jan 2009 10:34:15 +0530 Message-Id: <1231131855.16019.2.camel@jaswinder.satnam> Mime-Version: 1.0 X-Mailer: Evolution 2.22.1 (2.22.1-2.fc9) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1917 Lines: 76 On Sun, 2009-01-04 at 21:34 +0100, Ingo Molnar wrote: > yeah - i mentioned it to you before that there are such cases. > OK, so here is new patch excluding smp.h: [PATCH] x86: setup.c fix style problems Impact: cleanup Fix: WARNING: Use #include instead of WARNING: Use #include instead of WARNING: externs should be avoided in .c files ERROR: code indent should use tabs where possible total: 2 errors, 3 warnings Signed-off-by: Jaswinder Singh Rajput --- arch/x86/kernel/setup.c | 9 +++------ 1 files changed, 3 insertions(+), 6 deletions(-) diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c index ae0d804..57e76ca 100644 --- a/arch/x86/kernel/setup.c +++ b/arch/x86/kernel/setup.c @@ -66,6 +66,7 @@ #include #include +#include #include