Date: Mon, 5 Jan 2009 11:13:21 +0000
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Heikki Orsila <shdl@zakalwe.fi>
Cc: unsik Kim <donari75@gmail.com>, linux-kernel@vger.kernel.org,
       akpm@linux-foundation.org
Subject: Re: [PATCH] mflash linux support
Message-ID: <20090105111321.7d210c01@lxorguk.ukuu.org.uk>
In-Reply-To: <20090105023346.GE6115@zakalwe.fi>
References: <57afda040901041718g1415e210hfd0991270dfdd72d@mail.gmail.com>
	<20090105023346.GE6115@zakalwe.fi>
Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street,
 Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a
 Lloegr o'r rhif cofrestru 3798903
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 846
Lines: 26

On Mon, 5 Jan 2009 04:33:46 +0200
Heikki Orsila <shdl@zakalwe.fi> wrote:

> A few style issues:

How about starting by worrying about the code not pointless style
complaints ?

>> > +	switch (cmd) {
> > +	case HDIO_GETGEO:
> 
> 	if (cmd == HDIO_GETGEO) {

Especially when you are making pointless complaints about things that are
generally done the way the original code is - and for good reason. It
makes it far cleaner to add new ioctl support.


It would be interesting to see what mflash looked like as a libata driver
but I think for embedded systems the driver as submitted shows great
promise.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/