Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754815AbZAEN61 (ORCPT ); Mon, 5 Jan 2009 08:58:27 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752734AbZAEN6P (ORCPT ); Mon, 5 Jan 2009 08:58:15 -0500 Received: from mo-p00-ob.rzone.de ([81.169.146.161]:63872 "EHLO mo-p00-ob.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752156AbZAEN6O (ORCPT ); Mon, 5 Jan 2009 08:58:14 -0500 X-RZG-CLASS-ID: mo00 X-RZG-AUTH: :I2ANY0W6W/eA95XfH/xfO6gOxLxTty/udEMngcJ/VAKW226lDNJVyuUIJTI8OLkx Message-ID: <496211F3.3000003@hartkopp.net> Date: Mon, 05 Jan 2009 14:58:11 +0100 From: Oliver Hartkopp User-Agent: Mozilla-Thunderbird 2.0.0.17 (X11/20081018) MIME-Version: 1.0 To: Jaswinder Singh Rajput CC: davem@redhat.com, jgarzik@redhat.com, netdev , LKML , linux-next@vger.kernel.org, mchan@broadcom.com Subject: Re: [PATCH -net-next 3/4] firmware: convert tg3 driver to request_firmware() References: <1230626497.24796.26.camel@jaswinder.satnam> <49620AFE.6040409@hartkopp.net> In-Reply-To: <49620AFE.6040409@hartkopp.net> Content-Type: multipart/mixed; boundary="------------020105050708070105090509" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 13896 Lines: 185 This is a multi-part message in MIME format. --------------020105050708070105090509 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Oliver Hartkopp wrote: > > > 2. I got this inconsistent lock state, i've not seen before: > Hm - that was not completely correct 8-> I found some more of these lock state issues in my /var/log/kern.log but all of them are in the tg3 receive path ... (attached). So this problem seems not to come from your request_firmware() conversion. Maybe there was some other change in the 2.6.28-git that causes these tg3 problems. Regards, Oliver --------------020105050708070105090509 Content-Type: text/plain; name="tg3lockstate1" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="tg3lockstate1" Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752455] Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752459] ================================= Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752467] [ INFO: inconsistent lock state ] Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752473] 2.6.28-05692-g7d3b56b #4 Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752477] --------------------------------- Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752483] inconsistent {softirq-on-W} -> {in-softirq-W} usage. Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752490] swapper/0 [HC0[0]:SC1[1]:HE1:SE0] takes: Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752495] (&fbc->lock){-+..}, at: [] __percpu_counter_add+0x52/0x7a Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752514] {softirq-on-W} state was registered at: Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752518] [] __lock_acquire+0x2c4/0xb22 Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752530] [] lock_acquire+0x5d/0x7a Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752540] [] _spin_lock+0x1b/0x2a Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752550] [] __percpu_counter_sum+0xd/0x51 Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752559] [] ext3_statfs+0xb5/0x159 Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752568] [] vfs_statfs+0x3c/0x55 Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752577] [] sys_statfs64+0x44/0x80 Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752587] [] sysenter_do_call+0x12/0x35 Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752596] [] 0xffffffff Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752613] irq event stamp: 566114 Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752618] hardirqs last enabled at (566114): [] free_hot_cold_page+0x138/0x163 Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752629] hardirqs last disabled at (566113): [] free_hot_cold_page+0x83/0x163 Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752639] softirqs last enabled at (566060): [] __do_softirq+0x135/0x13d Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752651] softirqs last disabled at (566083): [] do_softirq+0x3a/0x52 Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752661] Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752663] other info that might help us debug this: Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752669] 3 locks held by swapper/0: Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752673] #0: (rcu_read_lock){..--}, at: [] netif_receive_skb+0xb0/0x25f Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752690] #1: (rcu_read_lock){..--}, at: [] ip_local_deliver+0x49/0x145 Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752706] #2: (slock-AF_INET/1){-+..}, at: [] tcp_v4_rcv+0x20b/0x4fd Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752724] Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752726] stack backtrace: Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752732] Pid: 0, comm: swapper Not tainted 2.6.28-05692-g7d3b56b #4 Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752738] Call Trace: Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752748] [] ? printk+0xf/0x11 Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752757] [] valid_state+0x12a/0x13d Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752766] [] mark_lock+0x133/0x340 Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752776] [] __lock_acquire+0x242/0xb22 Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752785] [] ? mark_lock+0x1e/0x340 Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752794] [] ? mark_held_locks+0x53/0x6a Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752803] [] lock_acquire+0x5d/0x7a Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752812] [] ? __percpu_counter_add+0x52/0x7a Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752820] [] _spin_lock+0x1b/0x2a Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752828] [] ? __percpu_counter_add+0x52/0x7a Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752837] [] __percpu_counter_add+0x52/0x7a Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752845] [] tcp_v4_destroy_sock+0x15b/0x164 Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752854] [] inet_csk_destroy_sock+0x87/0xf4 Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752862] [] tcp_done+0x5d/0x60 Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752872] [] tcp_rcv_state_process+0x7a6/0x883 Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752880] [] ? tcp_v4_rcv+0x20b/0x4fd Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752887] [] tcp_v4_do_rcv+0x114/0x15d Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752895] [] tcp_v4_rcv+0x31a/0x4fd Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752904] [] ip_local_deliver+0xb2/0x145 Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752911] [] ip_rcv+0x3d1/0x3fb Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752921] [] ? packet_rcv_spkt+0x9c/0xa4 Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752930] [] netif_receive_skb+0x22c/0x25f Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752940] [] tg3_poll+0x6a6/0x8bf Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752949] [] net_rx_action+0x62/0x143 Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752958] [] __do_softirq+0x8f/0x13d Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752966] [] do_softirq+0x3a/0x52 Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752975] [] irq_exit+0x44/0x7b Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752983] [] do_IRQ+0x92/0xa8 Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.752991] [] common_interrupt+0x2c/0x34 Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.753001] [] ? ____call_usermodehelper+0x85/0x124 Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.753011] [] ? acpi_idle_enter_simple+0x151/0x182 Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.753021] [] acpi_idle_enter_bm+0xc6/0x2a4 Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.753032] [] cpuidle_idle_call+0x60/0x93 Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.753039] [] cpu_idle+0x73/0x96 Jan 4 15:02:48 vwagwolkf320 kernel: [ 112.753048] [] start_secondary+0x19c/0x1a4 --------------020105050708070105090509 Content-Type: text/plain; name="tg3lockstate2" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="tg3lockstate2" Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.800876] Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.800878] ================================= Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.800884] [ INFO: inconsistent lock state ] Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.800888] 2.6.28-03164-g11df0b0 #6 Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.800891] --------------------------------- Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.800894] inconsistent {softirq-on-W} -> {in-softirq-W} usage. Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.800899] swapper/0 [HC0[0]:SC1[1]:HE1:SE0] takes: Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.800902] (&fbc->lock){-+..}, at: [] __percpu_counter_add+0x52/0x7a Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.800915] {softirq-on-W} state was registered at: Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.800919] [] __lock_acquire+0x2a6/0xadd Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.800926] [] lock_acquire+0x5d/0x7a Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.800933] [] _spin_lock+0x1b/0x2a Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.800939] [] __percpu_counter_sum+0xd/0x4a Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.800949] [] ext3_statfs+0xb5/0x159 Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.800953] [] vfs_statfs+0x3c/0x55 Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.800958] [] sys_statfs64+0x44/0x80 Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.800961] [] sysenter_do_call+0x12/0x35 Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.800965] [] 0xffffffff Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.800974] irq event stamp: 976438 Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.800976] hardirqs last enabled at (976438): [] free_hot_cold_page+0x138/0x163 Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.800980] hardirqs last disabled at (976437): [] free_hot_cold_page+0x83/0x163 Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.800984] softirqs last enabled at (976396): [] __do_softirq+0x135/0x13d Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.800989] softirqs last disabled at (976407): [] do_softirq+0x3a/0x52 Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.800993] Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.800994] other info that might help us debug this: Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.800996] 3 locks held by swapper/0: Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.800998] #0: (rcu_read_lock){..--}, at: [] netif_receive_skb+0xb0/0x25f Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.801005] #1: (rcu_read_lock){..--}, at: [] ip_local_deliver+0x49/0x145 Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.801011] #2: (slock-AF_INET/1){-+..}, at: [] tcp_v4_rcv+0x20b/0x4fd Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.801019] Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.801019] stack backtrace: Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.801022] Pid: 0, comm: swapper Not tainted 2.6.28-03164-g11df0b0 #6 Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.801024] Call Trace: Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.801028] [] ? printk+0xf/0x11 Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.801032] [] valid_state+0x12a/0x13d Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.801036] [] mark_lock+0x133/0x330 Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.801039] [] __lock_acquire+0x229/0xadd Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.801043] [] ? mark_lock+0x1e/0x330 Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.801046] [] ? mark_held_locks+0x53/0x6a Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.801050] [] lock_acquire+0x5d/0x7a Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.801053] [] ? __percpu_counter_add+0x52/0x7a Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.801056] [] _spin_lock+0x1b/0x2a Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.801060] [] ? __percpu_counter_add+0x52/0x7a Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.801063] [] __percpu_counter_add+0x52/0x7a Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.801067] [] tcp_v4_destroy_sock+0x15b/0x164 Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.801071] [] inet_csk_destroy_sock+0x73/0xe0 Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.801074] [] tcp_done+0x5d/0x60 Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.801078] [] tcp_rcv_state_process+0x7a6/0x884 Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.801081] [] ? tcp_v4_rcv+0x20b/0x4fd Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.801084] [] tcp_v4_do_rcv+0x114/0x15d Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.801087] [] tcp_v4_rcv+0x31a/0x4fd Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.801090] [] ip_local_deliver+0xb2/0x145 Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.801093] [] ip_rcv+0x3d1/0x3fb Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.801097] [] ? packet_rcv_spkt+0x9c/0xa4 Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.801100] [] netif_receive_skb+0x22c/0x25f Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.801104] [] tg3_poll+0x6a6/0x8bf Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.801109] [] net_rx_action+0x62/0x13e Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.801112] [] __do_softirq+0x8f/0x13d Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.801116] [] do_softirq+0x3a/0x52 Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.801119] [] irq_exit+0x44/0x83 Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.801122] [] do_IRQ+0x96/0xac Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.801125] [] common_interrupt+0x2c/0x34 Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.801130] [] ? usermodehelper_disable+0x89/0xa3 Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.801134] [] ? acpi_idle_enter_simple+0x151/0x182 Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.801138] [] acpi_idle_enter_bm+0xc6/0x2a4 Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.801142] [] cpuidle_idle_call+0x60/0x93 Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.801145] [] cpu_idle+0x70/0x93 Jan 4 15:49:56 vwagwolkf320 kernel: [ 374.801149] [] start_secondary+0x19a/0x1a2 --------------020105050708070105090509-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/