Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755049AbZAEPjW (ORCPT ); Mon, 5 Jan 2009 10:39:22 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754418AbZAEPjO (ORCPT ); Mon, 5 Jan 2009 10:39:14 -0500 Received: from ug-out-1314.google.com ([66.249.92.173]:44199 "EHLO ug-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754276AbZAEPjN (ORCPT ); Mon, 5 Jan 2009 10:39:13 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=PKwm4Ef99huos3EPFOVd0hcBb2rpNHwkEufL4tZendMX6kiWa0Y9F/IZGdTOgYwhzx FGYqIppaZRJ/zid9W15BjP6+rRXpEJVRsMj1ab4UrNR3tbB8EgcOkICQ0ah2zfYsqT93 TVdc7FYUGnhO2aBoiYXrNHiUvR9lm95wop4HE= Message-ID: <4962299B.6030108@gmail.com> Date: Mon, 05 Jan 2009 16:39:07 +0100 From: Jiri Slaby User-Agent: Thunderbird 2.0.0.19 (X11/20081227) MIME-Version: 1.0 To: Cyrill Gorcunov CC: Andi Kleen , Johannes Weiner , Robert Hancock , linux-kernel@vger.kernel.org, david@lang.hm, Andrew Morton Subject: Re: early exception error References: <20090101041727.GW496@one.firstfloor.org> <20090102172426.GB5372@localhost> <495E7FAD.6020305@shaw.ca> <20090105092619.GA3699@cmpxchg.org> <20090105130836.GN496@one.firstfloor.org> <49621E6E.2010809@gmail.com> <20090105150150.GF7645@localhost> <496223C4.20307@gmail.com> <20090105153025.GH7645@localhost> In-Reply-To: <20090105153025.GH7645@localhost> X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1032 Lines: 30 On 01/05/2009 04:30 PM, Cyrill Gorcunov wrote: > [Jiri Slaby - Mon, Jan 05, 2009 at 04:14:12PM +0100] > | On 01/05/2009 04:01 PM, Cyrill Gorcunov wrote: > | > [Jiri Slaby - Mon, Jan 05, 2009 at 03:51:26PM +0100] > | > | On 01/05/2009 02:08 PM, Andi Kleen wrote: > | > | > +#define EARLY_BUG_ON(x) do {} while(0) > | > | > | > | Shouldn't be x referenced here? > | > | > | > > | > but for what? > | > | I know, core devs are sane, but e.g. for reasons such as > | > | {'a' is used here already} > | EARLY_BUG_ON(!(a = readl(...))) > | {use 'a' again} > | > | to stay on the safe side. > > I wouldn't populate this style Jiri. It become more complicated > as it should to be, agreed? No, I tend to disagree. Macros should evaluate argument(s) the same no matter what is in .config. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/