Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753152AbZAER0V (ORCPT ); Mon, 5 Jan 2009 12:26:21 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751903AbZAER0N (ORCPT ); Mon, 5 Jan 2009 12:26:13 -0500 Received: from 8bytes.org ([88.198.83.132]:48391 "EHLO 8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751552AbZAER0M (ORCPT ); Mon, 5 Jan 2009 12:26:12 -0500 Date: Mon, 5 Jan 2009 18:26:08 +0100 From: Joerg Roedel To: FUJITA Tomonori Cc: mingo@elte.hu, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/8] add map_page and unmap_page to struct dma_mapping_ops Message-ID: <20090105172608.GB14298@8bytes.org> References: <1231166848-20149-1-git-send-email-fujita.tomonori@lab.ntt.co.jp> <1231166848-20149-2-git-send-email-fujita.tomonori@lab.ntt.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1231166848-20149-2-git-send-email-fujita.tomonori@lab.ntt.co.jp> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1865 Lines: 47 On Mon, Jan 05, 2009 at 11:47:21PM +0900, FUJITA Tomonori wrote: > This patch adds map_page and unmap_page to struct dma_mapping_ops. > > This is a preparation of struct dma_mapping_ops unification. We use > map_page and unmap_page instead of map_single and unmap_single. > > We will remove map_single and unmap_single hooks in the last patch in > this patchset. > > Signed-off-by: FUJITA Tomonori > --- > arch/x86/include/asm/dma-mapping.h | 8 ++++++++ > 1 files changed, 8 insertions(+), 0 deletions(-) > > diff --git a/arch/x86/include/asm/dma-mapping.h b/arch/x86/include/asm/dma-mapping.h > index e93265c..2f89d2e 100644 > --- a/arch/x86/include/asm/dma-mapping.h > +++ b/arch/x86/include/asm/dma-mapping.h > @@ -8,6 +8,7 @@ > > #include > #include > +#include > #include > #include > #include > @@ -51,6 +52,13 @@ struct dma_mapping_ops { > void (*unmap_sg)(struct device *hwdev, > struct scatterlist *sg, int nents, > int direction); > + dma_addr_t (*map_page)(struct device *dev, struct page *page, > + unsigned long offset, size_t size, > + enum dma_data_direction dir, > + struct dma_attrs *attrs); > + void (*unmap_page)(struct device *dev, dma_addr_t dma_handle, > + size_t size, enum dma_data_direction dir, > + struct dma_attrs *attrs); Why do we need an offset into the page? The name suggests that this function maps a whole page so the offset should be irrelevant. Joerg -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/