Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755341AbZAETnz (ORCPT ); Mon, 5 Jan 2009 14:43:55 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752459AbZAETnp (ORCPT ); Mon, 5 Jan 2009 14:43:45 -0500 Received: from einhorn.in-berlin.de ([192.109.42.8]:50372 "EHLO einhorn.in-berlin.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752616AbZAETno (ORCPT ); Mon, 5 Jan 2009 14:43:44 -0500 X-Envelope-From: stefanr@s5r6.in-berlin.de Date: Mon, 5 Jan 2009 20:43:23 +0100 (CET) From: Stefan Richter Subject: [PATCH] firewire: ohci: change "context_stop: still active" log message To: linux1394-devel@lists.sourceforge.net cc: linux-kernel@vger.kernel.org Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; CHARSET=us-ascii Content-Disposition: INLINE Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1170 Lines: 37 The present message is mostly just noise. We only need to be notified if the "active" flag does not go off before the retry loop terminates. Signed-off-by: Stefan Richter --- drivers/firewire/fw-ohci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: linux/drivers/firewire/fw-ohci.c =================================================================== --- linux.orig/drivers/firewire/fw-ohci.c +++ linux/drivers/firewire/fw-ohci.c @@ -892,11 +892,11 @@ static void context_stop(struct context for (i = 0; i < 10; i++) { reg = reg_read(ctx->ohci, CONTROL_SET(ctx->regs)); if ((reg & CONTEXT_ACTIVE) == 0) - break; + return; - fw_notify("context_stop: still active (0x%08x)\n", reg); mdelay(1); } + fw_error("Error: DMA context still active (0x%08x)\n", reg); } struct driver_data { -- Stefan Richter -=====-==--= ---= --=-= http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/