Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754685AbZAETqf (ORCPT ); Mon, 5 Jan 2009 14:46:35 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752162AbZAETqW (ORCPT ); Mon, 5 Jan 2009 14:46:22 -0500 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.123]:38863 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751991AbZAETqV (ORCPT ); Mon, 5 Jan 2009 14:46:21 -0500 Date: Mon, 5 Jan 2009 14:46:19 -0500 (EST) From: Steven Rostedt X-X-Sender: rostedt@gandalf.stny.rr.com To: Sam Ravnborg cc: LKML , Steven Rostedt , Ingo Molnar , "David S. Miller" , sparclinux Subject: Re: [PATCH] sparc: make proces_ver_nack a bit more readable In-Reply-To: Message-ID: References: <20090105181922.GA25622@uranus.ravnborg.org> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2111 Lines: 74 On Mon, 5 Jan 2009, Steven Rostedt wrote: > > Impact: clean up > > The code in process_ver_nack is a little obfuscated. This change > makes it a bit more readable by humans. It removes the complex > if statement and replaces it with a cleaner flow of control. Note, I do not have a sparc compiler at my disposal, so I was not able to compile (or boot) test this change. Here's the original code: static int process_ver_nack(struct ldc_channel *lp, struct ldc_version *vp) { struct ldc_version *vap; if ((vp->major == 0 && vp->minor == 0) || !(vap = find_by_major(vp->major))) { return ldc_abort(lp); } else { struct ldc_packet *p; unsigned long new_tail; p = handshake_compose_ctrl(lp, LDC_INFO, LDC_VERS, vap, sizeof(*vap), &new_tail); if (p) return send_tx_packet(lp, p, new_tail); else return ldc_abort(lp); } } And the new code: static int process_ver_nack(struct ldc_channel *lp, struct ldc_version *vp) { struct ldc_version *vap; struct ldc_packet *p; unsigned long new_tail; if (vp->major == 0 && vp->minor == 0) return ldc_abort(lp); vap = find_by_major(vp->major); if (!vap) return ldc_abort(lp); p = handshake_compose_ctrl(lp, LDC_INFO, LDC_VERS, vap, sizeof(*vap), &new_tail); if (!p) return ldc_abort(lp); return send_tx_packet(lp, p, new_tail); } This should be binary the same. But as I said, I do not have a sparc compiler to test. Thanks, -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/