Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755387AbZAEUG2 (ORCPT ); Mon, 5 Jan 2009 15:06:28 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752419AbZAEUGS (ORCPT ); Mon, 5 Jan 2009 15:06:18 -0500 Received: from pfepb.post.tele.dk ([195.41.46.236]:51185 "EHLO pfepb.post.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751302AbZAEUGS (ORCPT ); Mon, 5 Jan 2009 15:06:18 -0500 Date: Mon, 5 Jan 2009 21:07:58 +0100 From: Sam Ravnborg To: Steven Rostedt Cc: LKML , Steven Rostedt , Ingo Molnar , "David S. Miller" , sparclinux Subject: Re: [PATCH] sparc: make proces_ver_nack a bit more readable Message-ID: <20090105200758.GC6204@uranus.ravnborg.org> References: <20090105181922.GA25622@uranus.ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 951 Lines: 28 On Mon, Jan 05, 2009 at 02:56:58PM -0500, Steven Rostedt wrote: > > On Mon, 5 Jan 2009, Steven Rostedt wrote: > > > > > Impact: clean up > > > > The code in process_ver_nack is a little obfuscated. This change > > makes it a bit more readable by humans. It removes the complex > > if statement and replaces it with a cleaner flow of control. > > > > Signed-off-by: Steven Rostedt > > Sam, > > Can you test to see if this patch makes the issue go away. Obviously, Dave > would need to be the one to pull it in, or at least ack it. As expected the patch silence the warning. The warning only triggers when we have an assignment after a boolean || inside an if condition. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/