Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754636AbZAEVgL (ORCPT ); Mon, 5 Jan 2009 16:36:11 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753375AbZAEVf5 (ORCPT ); Mon, 5 Jan 2009 16:35:57 -0500 Received: from wa-out-1112.google.com ([209.85.146.178]:15581 "EHLO wa-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752490AbZAEVf4 (ORCPT ); Mon, 5 Jan 2009 16:35:56 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references:x-google-sender-auth; b=xpe30inGj8HTg8KYLt6S75nknQFdP3B9jXeXHBLeN5xVoqjTzgnFPBdGcNhjdrCTI+ ws7W5Gtki5CcqBl2K9SIQxlA8YMPZpIV7Tgeha5YTnf2RUhoJMsHF6DaTWZWgFkykEoZ XRmdnbkfvRH2Ve+TJrYrrAzy/M/A9WfY+7jUs= Message-ID: Date: Mon, 5 Jan 2009 14:35:55 -0700 From: "Dan Williams" To: "Guennadi Liakhovetski" Subject: Re: [PATCH 0/4 v6] i.MX31: dmaengine and framebuffer drivers Cc: linux-kernel@vger.kernel.org, linux-fbdev-devel@lists.sourceforge.net, adaplas@gmail.com, "Sascha Hauer" , linux-arm-kernel@lists.arm.linux.org.uk, "Geert Uytterhoeven" In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: X-Google-Sender-Auth: 19a932e41b048d00 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2295 Lines: 62 On Mon, Jan 5, 2009 at 2:02 PM, Guennadi Liakhovetski wrote: > On Mon, 5 Jan 2009, Dan Williams wrote: > >> On Fri, Dec 26, 2008 at 10:11 AM, Guennadi Liakhovetski >> wrote: >> > Hi, >> > >> > This is version 6 of dmaengine and framebuffer drivers for i.MX31. >> > >> >> Tha drivers/dma/ bits look ok to me minus the new warnings: >> >> drivers/dma/ipu/ipu_irq.c: In function 'ipu_irq_fn': >> drivers/dma/ipu/ipu_irq.c:328: warning: 'irq' may be used >> uninitialized in this function >> drivers/dma/ipu/ipu_irq.c: In function 'ipu_irq_err': >> drivers/dma/ipu/ipu_irq.c:290: warning: 'irq' may be used >> uninitialized in this function > > Wow... with what gcc version? My 4.1.2 correctly recognises, that it > _doesn't_ get used uninitialised. hmm... this was with: $ arm-none-linux-gnueabi-gcc --version arm-none-linux-gnueabi-gcc (CodeSourcery Sourcery G++ Lite 2007q1-21) 4.2.0 20070413 (prerelease) ...and also with: $ arm-none-linux-gnueabi-gcc --version arm-none-linux-gnueabi-gcc (Sourcery G++ Lite 2008q3-72) 4.3.2 >> I can take patches 1 and 2 through the async_tx tree, or if you would >> rather, add my Acked-by to those and take 1-4 through the MXC tree. >> I'll be sending the async_tx pull request for 2.6.29 in the next few >> days. > > Thanks, great! Don't know what's better, let's see what Sascha says. But > there's one small problem with the patch 2/4: it breaks compilation on > i.MX31 if IPU is _not_ set, so, default imx31 configs would break:-( The > problem is, that I use CONFIG_MX3_IPU_IRQS unconditionally in calculation > of NR_IRQ. The easiest for me is to fix it in mx31.h like > > #ifdef CONFIG_MX3_IPU_IRQS > #define MX3_IPU_IRQS CONFIG_MX3_IPU_IRQS > #else > #define MX3_IPU_IRQS 0 > #endif > > but that's less than elegant:-) A probably better solution would be to fix > this in Kconfig, best would be to show I think the header file is the proper place for this... the Kconfig trickery ends up being just another way to say !CONFIG_MX3_IPU_IRQS. Regards, Dan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/