Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754750AbZAEVwS (ORCPT ); Mon, 5 Jan 2009 16:52:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753589AbZAEVwI (ORCPT ); Mon, 5 Jan 2009 16:52:08 -0500 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.123]:49341 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753092AbZAEVwG (ORCPT ); Mon, 5 Jan 2009 16:52:06 -0500 Date: Mon, 5 Jan 2009 16:52:02 -0500 (EST) From: Steven Rostedt X-X-Sender: rostedt@gandalf.stny.rr.com To: Sam Ravnborg cc: LKML , Steven Rostedt , Ingo Molnar , "David S. Miller" , sparclinux Subject: Re: ftrace breaks sparc64 build In-Reply-To: <20090105213107.GA27293@uranus.ravnborg.org> Message-ID: References: <20090105181922.GA25622@uranus.ravnborg.org> <20090105195415.GA6204@uranus.ravnborg.org> <20090105213107.GA27293@uranus.ravnborg.org> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1986 Lines: 54 On Mon, 5 Jan 2009, Sam Ravnborg wrote: > > > > Probably the same issue. The problem is that the first use of a variable > > is in the OR section of an if statement that does a return. > > > > if (x || !(y = init_me()) > > return; > > > > use_me(y); > > > > More warnings: > fs/partitions/check.c: In function `rescan_partitions': > fs/partitions/check.c:511: warning: 'state' might be used uninitialized in this function > > => follow same pattern > > fs/compat_ioctl.c: In function `ppp_sock_fprog_ioctl_trans': > fs/compat_ioctl.c:859: warning: 'fptr32' might be used uninitialized in this function > fs/compat_ioctl.c: In function `do_fontx_ioctl': > fs/compat_ioctl.c:1082: warning: 'data' might be used uninitialized in this function > fs/compat_ioctl.c: In function `do_atmif_sioc': > fs/compat_ioctl.c:1302: warning: 'data' might be used uninitialized in this function > fs/compat_ioctl.c: In function `do_atm_ioctl': > fs/compat_ioctl.c:1272: warning: 'data' might be used uninitialized in this function > fs/compat_ioctl.c: In function `mtd_rw_oob': > fs/compat_ioctl.c:1421: warning: 'data' might be used uninitialized in this function > fs/compat_ioctl.c: In function `do_usbdevfs_discsignal': > fs/compat_ioctl.c:1650: warning: 'uctx' might be used uninitialized in this function > > This is: > if (get_user(flen, &u_fprog32->len) || > get_user(fptr32, &u_fprog32->filter)) > return -EFAULT; Is this all sparc cross compiler? I'm trying to reproduce it on x86 with no avail :-( I would like to test other ways to change the macro, but to do so, I need to get a compiler that will produce the warnings that you see. What version of gcc are you using? Thanks, -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/