DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=pacbell.net;
  h=Received:X-YMail-OSG:X-Yahoo-Newman-Property:From:To:Subject:Date:User-Agent:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-Disposition:Message-Id;
  b=cVUYojF8i5TJRgGOHqsdEVhaB6FyPUg1m8bSNpdzv2DMxN7ocUG+7tgVC7l4s7gvq7E8k5n4DRo67wA+F4QSyQ9eDE6p5dj1LugCKIPXQnaX2h7S/EpDCeF9c8AE9sXlUOklQm1Uo0RR0raVW4eto10n0/LNLzQtZQTcZH5BT5o=  ;
From: David Brownell <david-b@pacbell.net>
To: sangsu <sangsu@gmail.com>
Subject: Re: [PATCH]USB:Fix goku_udc usb speed handling
Date: Mon, 5 Jan 2009 14:46:08 -0800
User-Agent: KMail/1.9.10
Cc: linux-usb@vger.kernel.org, stern@rowland.harvard.edu,
       linux-kernel@vger.kernel.org
References: <20090101161114.GA7977@sangsu-desktop>
In-Reply-To: <20090101161114.GA7977@sangsu-desktop>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200901051446.09047.david-b@pacbell.net>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1238
Lines: 40

On Thursday 01 January 2009, sangsu wrote:
> The usb gadget framework revealed weakness in the godu_udc
> gadget driver register function. Instead of checking if 
> speed asked for was USB_LOW_SPEED upon usb_gadget_register()
> to deny service, it checked only for USB_FULL_SPEED, thus
> denying service to usb high speed capable gadgets.
> 
> Signed-off-by: SangSu Park<sangsu@gmail.com>

Acked-by: David Brownell <dbrownell@users.sourceforge.net>


Good to know this USB peripheral driver is getting some use.  :)


> ---
> drivers/usb/gadget/goku_udc.c |2+-
> 1 files changed, 1 insertion(+), 1 deletions(-)
> 
> 
> --- a/drivers/usb/gadget/goku_udc.c	2008-12-30 23:24:02.000000000 +0900
> +++ b/drivers/usb/gadget/goku_udc.c	2009-01-02 00:49:15.000000000 +0900
> @@ -1349,7 +1349,7 @@
>  	int			retval;
>  
>  	if (!driver
> -			|| driver->speed != USB_SPEED_FULL
> +			|| driver->speed < USB_SPEED_FULL
>  			|| !driver->bind
>  			|| !driver->disconnect
>  			|| !driver->setup)
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/