Date: Mon, 05 Jan 2009 16:01:12 -0800 (PST)
Message-Id: <20090105.160112.119906029.davem@davemloft.net>
To: oliver@hartkopp.net
Cc: jaswinder@infradead.org, jgarzik@redhat.com, netdev@vger.kernel.org,
       linux-kernel@vger.kernel.org, linux-next@vger.kernel.org,
       mchan@broadcom.com, mike@marineau.org
Subject: Re: [PATCH -net-next 3/4] firmware: convert tg3 driver to
 request_firmware()
From: David Miller <davem@davemloft.net>
In-Reply-To: <49620AFE.6040409@hartkopp.net>
References: <1230626497.24796.26.camel@jaswinder.satnam>
	<49620AFE.6040409@hartkopp.net>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 926
Lines: 24

From: Oliver Hartkopp <oliver@hartkopp.net>
Date: Mon, 05 Jan 2009 14:28:30 +0100

> 2. I got this inconsistent lock state, i've not seen before:

I know what causes it.  It's this change:

commit 22604c866889c4b2e12b73cbf1683bda1b72a313
Author: Michael Marineau <mike@marineau.org>
Date:   Sun Jan 4 17:18:51 2009 -0800

    net: Fix for initial link state in 2.6.28

It causes us to now call the linkwatch even trigger code inside of
software interrupt context, but that is illegal because that code path
takes the dev_base_lock rwlock as a writer.

I'm going to revert, and Michael will need to find a way to fix the
initial link state issue without adding locking problems :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/