DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=pacbell.net;
  h=Received:X-YMail-OSG:X-Yahoo-Newman-Property:From:To:Subject:Date:User-Agent:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-Disposition:Message-Id;
  b=fIX9zdWMrimMkUnY/vkmTTCzSvhjtFyuvq4dC7oq+Ze5+YNmOvJ2Z/iwVyN/7dhQuqmameA4ewSofhQyRen67Wrq4ml83/qwAwNtIFFy8z1mqWZGaloSuc/T9FLFI8elVgsdjuJw9Sf8dhBsFGz2B6mp0Z+7ofbz8tKM8VEIU/k=  ;
From: David Brownell <david-b@pacbell.net>
To: Mark Brown <broonie@sirena.org.uk>
Subject: Re: [patch 2.6.28-rc7] regulator: catch some registration errors
Date: Mon, 5 Jan 2009 15:45:04 -0800
User-Agent: KMail/1.9.10
Cc: lrg@slimlogic.co.uk, lkml <linux-kernel@vger.kernel.org>
References: <200812011335.43551.david-b@pacbell.net> <200812012150.36342.david-b@pacbell.net> <20081202133228.GD7940@sirena.org.uk>
In-Reply-To: <20081202133228.GD7940@sirena.org.uk>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Message-Id: <200901051545.04912.david-b@pacbell.net>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1285
Lines: 32

On Tuesday 02 December 2008, Mark Brown wrote:
> > Also make sure the consumer device is provided. ?It's nonsensical
> > to omit these, and not a documented part of the interface. ?Since
> > no code in mainline does such stuff, this is just anti-oops medicine.
> 
> ...we do still need to cater for cpufreq and other struct deviceless
> consumers. ?If you can guarantee that no such consumers will ever exist
> then great but we're not there yet.

Just for the record:  my feeling is that since no such
drivers currently use the regulator framework, it's wrong
to design-in breakage to support them.

When someone writes a cpufreq driver that uses the
regulator framework, they can arrange to provide the
relevant "struct device *" to make that work neatly.

Meanwhile, I still think the regulator framework should
be using driver model messages.  Since the only reason
not to use them is to support those non-existent drivers.

- Dave

p.s. Glad to see at least part of this patch get merged,
   even if related diagnostics are lacking.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/