Date: Tue, 06 Jan 2009 10:14:25 +0900 (JST)
Message-Id: <20090106.101425.109407744.nemoto@toshiba-tops.co.jp>
To: dan.j.williams@intel.com
Cc: anemo@mba.ocn.ne.jp, haavard.skinnemoen@atmel.com,
       linux-kernel@vger.kernel.org, hskinnemoen@atmel.com,
       maciej.sosnowski@intel.com, ralf@linux-mips.org
Subject: Re: [PATCH] dmatest: flush and invalidate destination buffer
 before DMA
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
In-Reply-To: <e9c3a7c20901051031y528d0d31r18d44c5096c59e0@mail.gmail.com>
References: <20081227111037.3bd13adc@hskinnemoen-d830>
	<20081229.025352.01917409.anemo@mba.ocn.ne.jp>
	<e9c3a7c20901051031y528d0d31r18d44c5096c59e0@mail.gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1727
Lines: 37

On Mon, 5 Jan 2009 11:31:57 -0700, "Dan Williams" <dan.j.williams@intel.com> wrote:
> > On nono-coherent MIPS platforms, dma_map_single() for DMA_TO_DEVICE
> > writeback the cache, dma_map_single() for DMA_FROM_DEVICE invalidated
> > (without writeback) the cache.  dma_unmap_simgle() is a nop.
> >
> > If dst_off was not cacheline aligned, dma_map_single(...,
> > DMA_FROM_DEVICE) in dma_async_memcpy_buf_to_buf() invalidate whole
> > cachelines including dst_off.  So, for example, the initialized data
> > at dst_off - 1 will be just discarded.  This result mismatch error of
> > course.  Same error can be happen at end of the real DMA area.
> >
> > I added dma_map_single/dma_unmap_single to just flush all dstbuf to
> > main memory.
> 
> I am tempted to say this is a bug in the MIPS dma_map_single
> implementation.  It is at least a difference in behavior from ARM
> where partial cachelines are cleaned+invalidated in the
> DMA_FROM_DEVICE case [1].

Yes, MIPS and ARM do different thing on partial cache line.  But I
suppose this belongs to "implementation dependent" area of DMA API so
users of the API should not depend on it.  (Well, maybe I'm biased to
MIPS ;-))

In general, drivers must not put normal data and DMA buffer on same
cacheline anyway to avoid unexpected writeback and data loss.  So this
ambiguity is not a problem.  IMHO writeback of the partial line for
DMA_FROM_DEVICE just _hides_ abusing of the DMA API and potential data
loss.

---
Atsushi Nemoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/