Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753452AbZAFCR6 (ORCPT ); Mon, 5 Jan 2009 21:17:58 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751893AbZAFCRs (ORCPT ); Mon, 5 Jan 2009 21:17:48 -0500 Received: from mx2.redhat.com ([66.187.237.31]:50810 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751869AbZAFCRr (ORCPT ); Mon, 5 Jan 2009 21:17:47 -0500 Date: Tue, 6 Jan 2009 02:16:58 +0000 From: Alasdair G Kergon To: Geert Uytterhoeven Cc: Stephen Rothwell , Milan Broz , Jaya Kumar , Laurent Pinchart , Mauro Carvalho Chehab , Gene Sally , Sam Ravnborg , Andrew Morton , linux-next@vger.kernel.org, LKML Subject: Re: strncat() misuse (was: Re: dm_attr_{name,uuid}_show buffer overflow? (was: Re: linux-next: Tree for January 5)) Message-ID: <20090106021658.GQ5098@agk.fab.redhat.com> Mail-Followup-To: Alasdair G Kergon , Geert Uytterhoeven , Stephen Rothwell , Milan Broz , Jaya Kumar , Laurent Pinchart , Mauro Carvalho Chehab , Gene Sally , Sam Ravnborg , Andrew Morton , linux-next@vger.kernel.org, LKML References: <20090105173517.deeff918.sfr@canb.auug.org.au> <20090106012759.GA3512@agk.fab.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090106012759.GA3512@agk.fab.redhat.com> User-Agent: Mutt/1.4.1i Organization: Red Hat UK Ltd. Registered in England and Wales, number 03798903. Registered Office: Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE. Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 782 Lines: 19 On Tue, Jan 06, 2009 at 01:27:59AM +0000, Alasdair G Kergon wrote: > On Mon, Jan 05, 2009 at 11:18:38PM +0100, Geert Uytterhoeven wrote: > > On Mon, 5 Jan 2009, Geert Uytterhoeven wrote: > > > On Mon, 5 Jan 2009, Stephen Rothwell wrote: > > > | strncat(buf, "\n", DM_NAME_LEN); > > > | return strnlen(buf, DM_NAME_LEN); I've edited the patch to use strcat and strlen. http://git.kernel.org/?p=linux/kernel/git/agk/linux-2.6-dm.git;a=commit;h=911950f88bfd8a6747a1c6da5c5410641845bc64 Alasdair -- agk@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/