Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753890AbZAFGeQ (ORCPT ); Tue, 6 Jan 2009 01:34:16 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751456AbZAFGeA (ORCPT ); Tue, 6 Jan 2009 01:34:00 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:41200 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751337AbZAFGd7 (ORCPT ); Tue, 6 Jan 2009 01:33:59 -0500 Subject: Re: [PATCH 04/11] x86: cleanup remaining cpumask_t ops in smpboot code From: Jaswinder Singh Rajput To: Mike Travis , Ingo Molnar , Rusty Russell , "H. Peter Anvin" , Thomas Gleixner , Linus Torvalds , Jack Steiner , LKML In-Reply-To: <1231222512.3235.6.camel@jaswinder.satnam> References: <1231222512.3235.6.camel@jaswinder.satnam> Content-Type: text/plain; charset=utf8 Date: Tue, 06 Jan 2009 12:01:20 +0530 Message-Id: <1231223480.3235.22.camel@jaswinder.satnam> Mime-Version: 1.0 X-Mailer: Evolution 2.22.1 (2.22.1-2.fc9) Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1546 Lines: 65 Hello Mike, On Sun, Jan 4, 2009 at 6:48 PM, Mike Travis wrote: > --- linux-2.6-for-ingo.orig/arch/x86/include/asm/smp.h > +++ linux-2.6-for-ingo/arch/x86/include/asm/smp.h > @@ -18,9 +18,26 @@ > #include > #include > > +#ifdef CONFIG_X86_64 > + > +extern cpumask_var_t cpu_callin_mask; > +extern cpumask_var_t cpu_callout_mask; > +extern cpumask_var_t cpu_initialized_mask; > +extern cpumask_var_t cpu_sibling_setup_mask; > + > +#else /* CONFIG_X86_32 */ > + > +extern cpumask_t cpu_callin_map; I am not able to understand, why you choose asm/smp.h You know that asm/smp.h should only be included for CONFIG_SMP ----- linux/smp.h ----- #ifdef CONFIG_SMP #include #endif /* !SMP */ ----------------------- If someday this will happen: ----- asm/smp.h ----- #ifndef _ASM_X86_SMP_H #define _ASM_X86_SMP_H #ifndef __ASSEMBLY__ #ifdef CONFIG_SMP ... #else /* CONFIG_SMP */ #error "Including wrong file, why you need smp.h for uniprocesor" #endif /* CONFIG_SMP */ #endif /* __ASSEMBLY__ */ #endif /* _ASM_X86_SMP_H */ ----------------------- Then ;-) Are you planning to make some new file for this or you think some other file will be suitable for this. If you have some future plans, please let me know. Thanks -- JSR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/