Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752729AbZAFJLm (ORCPT ); Tue, 6 Jan 2009 04:11:42 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751360AbZAFJLY (ORCPT ); Tue, 6 Jan 2009 04:11:24 -0500 Received: from tundra.namei.org ([65.99.196.166]:3601 "EHLO tundra.namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750944AbZAFJLX (ORCPT ); Tue, 6 Jan 2009 04:11:23 -0500 Date: Tue, 6 Jan 2009 20:11:00 +1100 (EST) From: James Morris To: Tetsuo Handa cc: akpm@linux-foundation.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, paulmck@linux.vnet.ibm.com Subject: Re: [TOMOYO #14 (mmotm 2008-12-30-16-05) 02/10] Singly linked list implementation. In-Reply-To: <200901060813.n068DI3Y023188@www262.sakura.ne.jp> Message-ID: References: <20090101050741.372438529@I-love.SAKURA.ne.jp> <20090101050939.802554261@I-love.SAKURA.ne.jp> <200901060813.n068DI3Y023188@www262.sakura.ne.jp> User-Agent: Alpine 1.10 (LRH 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2235 Lines: 77 On Tue, 6 Jan 2009, Tetsuo Handa wrote: > > James Morris wrote: > > This has a technical ack from Paul, but what about Linus' long-standing > > objection to singly-linked lists in the kernel? I'm sure this has been > > discussed re. your patches, but I can't find a reference. > I couldn't find one neither. (What does "re." mean?) http://en.wiktionary.org/wiki/re#Etymology_1 > But optimistically speaking, there are many in-tree users who define "struct" > without "prev" pointer. > > # grep -hr 'struct [a-zA-Z0-9_]* \*next;' linux-2.6.28/include/linux/ | wc -l > 42 > # grep -hr 'struct [a-zA-Z0-9_]* \*prev;' linux-2.6.28/include/linux/ | wc -l > 7 > > Not all structures listed below are used as singly linked list, > but many of them are used as singly linked list. Can any of these be converted to your singly linked list implementation ? > > struct sched_class; > struct acpi_pci_driver; > struct adb_request; > struct atalk_route; > struct core_thread; > struct dma_async_tx_descriptor; > struct erase_info; > struct esp_pio_buffer; > struct fdtable; > struct floppy_raw_cmd; > struct ftrace_ops; > struct hdlc_proto; > struct hwif_s; > struct ippp_buf_queue; > struct irqaction; > struct isdn_net_local_s; > struct kcore_list; > struct mfc6_cache; > struct mfc_cache; > struct nls_table; > struct notifier_block; > struct page_list; > struct pbe; > struct phone_device; > struct pnp_id; > struct r3964_block_header; > struct r3964_client_info; > struct r3964_message; > struct rcu_head; > struct resource_list; > struct sched_group; > struct sdio_func_tuple; > struct tasklet_struct; > struct tty_buffer; > struct xor_block_template; > > Thus, I believe it is acceptable that TOMOYO uses singly linked list > unless Linus comes out and yell "No!". He's yelled no in the past, so there needs to be a convincing argument which he'll accept. - James -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/