Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754106AbZAFJpu (ORCPT ); Tue, 6 Jan 2009 04:45:50 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751720AbZAFJpl (ORCPT ); Tue, 6 Jan 2009 04:45:41 -0500 Received: from mtagate2.uk.ibm.com ([194.196.100.162]:45739 "EHLO mtagate2.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750967AbZAFJpk (ORCPT ); Tue, 6 Jan 2009 04:45:40 -0500 Date: Tue, 6 Jan 2009 10:45:37 +0100 From: Heiko Carstens To: Steven Rostedt Cc: Sam Ravnborg , LKML , Steven Rostedt , Ingo Molnar , "David S. Miller" , sparclinux Subject: Re: ftrace breaks sparc64 build Message-ID: <20090106094537.GB5061@osiris.boeblingen.de.ibm.com> References: <20090105181922.GA25622@uranus.ravnborg.org> <20090105195415.GA6204@uranus.ravnborg.org> <20090105213107.GA27293@uranus.ravnborg.org> <20090105220156.GC8592@uranus.ravnborg.org> <20090105231136.GA5073@osiris.boeblingen.de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1035 Lines: 25 On Mon, Jan 05, 2009 at 11:30:58PM -0500, Steven Rostedt wrote: > On Tue, 6 Jan 2009, Heiko Carstens wrote: > Sam and Heiko, > > I'm trying to see if the (a ? b : c) construct is causing the issue. Can > you test this patch. > > diff --git a/include/linux/compiler.h b/include/linux/compiler.h > index d95da10..e13ad24 100644 > --- a/include/linux/compiler.h > +++ b/include/linux/compiler.h > @@ -113,7 +113,8 @@ void ftrace_likely_update(struct ftrace_branch_data *f, int val, int expect); > * "Define 'is'", Bill Clinton > * "Define 'if'", Steven Rostedt > */ > -#define if(cond) if (__builtin_constant_p((cond)) ? !!(cond) : \ > +#define if(cond) if ((__builtin_constant_p((cond)) && !!(cond)) || \ > + (!__builtin_constant_p((cond)) && \ Doesn't help unfortunately. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/