Date: Tue, 6 Jan 2009 11:17:10 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Andi Kleen <andi@firstfloor.org>
Cc: akpm@linux-foundation.org, x86@kernel.org, linux-kernel@vger.kernel.org,
       "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] [3/5] Mark complex bitops.h inlines as __always_inline
Message-ID: <20090106101710.GA22134@elte.hu>
References: <200901051236.281008835@firstfloor.org> <20090104233640.6A7453E6653@basil.firstfloor.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090104233640.6A7453E6653@basil.firstfloor.org>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 627
Lines: 20


* Andi Kleen <andi@firstfloor.org> wrote:

> Hugh Dickins noticed that older gcc versions when the kernel is built 
> for code size didn't inline some of the bitops.

Older GCCs have a whole lot more problems than suboptimal inlining 
decisions.

Your patch is wrong because it prevents a good compiler from doing the 
right inlining decisions.

So why should i apply this?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/